From: Joe Perches <joe@perches.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Frederic LAMBERT <frdrc66@gmail.com>,
kernel@pengutronix.de
Subject: Re: [PATCH] net: Micrel KSZ8864RMN 4-port managed switch support
Date: Wed, 02 Apr 2014 09:28:59 -0700 [thread overview]
Message-ID: <1396456139.32040.9.camel@joe-AO722> (raw)
In-Reply-To: <1396453816-32348-1-git-send-email-p.zabel@pengutronix.de>
On Wed, 2014-04-02 at 17:50 +0200, Philipp Zabel wrote:
> This patch adds support for the Micrel KSZ8864RMN switch to the spi_ks8995
> driver. The KSZ8864RMN switch has a wider 256-byte register space.
trivia:
> diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c
[]
> @@ -317,9 +341,14 @@ static int ks8995_probe(struct spi_device *spi)
> goto err_drvdata;
> }
>
> - dev_info(&spi->dev, "KS89%02X device found, Chip ID:%01x, "
> - "Revision:%01x\n", ids[0],
> - get_chip_id(ids[1]), get_chip_rev(ids[1]));
> + if (get_chip_id(ids[1]) == CHIPID_M) {
> + dev_info(&spi->dev,
> + "KS8995 device found, Chip ID:%01x, Revision:%01x\n",
Using %01x is kind of nonsensical. %x seems more sensible.
> + get_chip_id(ids[1]), get_chip_rev(ids[1]));
> + } else {
> + dev_info(&spi->dev, "KSZ8864 device found, Revision:%01x\n",
> + get_chip_rev(ids[1]));
> + }
here too
prev parent reply other threads:[~2014-04-02 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 15:50 [PATCH] net: Micrel KSZ8864RMN 4-port managed switch support Philipp Zabel
2014-04-02 16:28 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396456139.32040.9.camel@joe-AO722 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=frdrc66@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).