From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Vlad Yasevich <vyasevic@redhat.com>
Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH net] e1000e: Correctly include VLAN_HLEN when changing interface MTU
Date: Fri, 04 Apr 2014 15:22:41 -0700 [thread overview]
Message-ID: <1396650161.2300.7.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1396644528-32430-1-git-send-email-vyasevic@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
On Fri, 2014-04-04 at 16:48 -0400, Vlad Yasevich wrote:
> When changing the interface mtu, the driver starts with a value
> that doesn't include VLAN_HLEN. Later tests in the driver
> set the rx_buffer_len based on the mtu. As a result, when
> the user increases the mtu to 1504 (to support 802.1AD for example),
> the driver rx_buffer_len does not change and frames longer
> the 1522 bytes are rejected as too long.
>
> Include VLAN_HLEN from the start so that an user mtu greater then
> 1500 bytes is correctly reflected in the driver rx_buffer_len.
>
> CC: e1000-devel@lists.sourceforge.net
> CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks Vlad, I will add the patch to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2014-04-04 22:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 20:48 [PATCH net] e1000e: Correctly include VLAN_HLEN when changing interface MTU Vlad Yasevich
2014-04-04 22:22 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1396650161.2300.7.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).