* [PATCH] tipc: Let tipc_release() return 0
@ 2014-04-06 13:56 Geert Uytterhoeven
2014-04-07 19:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2014-04-06 13:56 UTC (permalink / raw)
To: Jon Maloy, Allan Stephens, David S. Miller
Cc: netdev, tipc-discussion, linux-kernel, Geert Uytterhoeven
net/tipc/socket.c: In function ‘tipc_release’:
net/tipc/socket.c:352: warning: ‘res’ is used uninitialized in this function
Introduced by commit 24be34b5a0c9114541891d29dff1152bb1a8df34 ("tipc:
eliminate upcall function pointers between port and socket"), which
removed the sole initializer of "res".
Just return 0 to fix it.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
net/tipc/socket.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 29b7f26a12cf..adc12e227303 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -301,7 +301,6 @@ static int tipc_release(struct socket *sock)
struct tipc_sock *tsk;
struct tipc_port *port;
struct sk_buff *buf;
- int res;
/*
* Exit if socket isn't fully initialized (occurs when a failed accept()
@@ -349,7 +348,7 @@ static int tipc_release(struct socket *sock)
sock_put(sk);
sock->sk = NULL;
- return res;
+ return 0;
}
/**
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] tipc: Let tipc_release() return 0
2014-04-06 13:56 [PATCH] tipc: Let tipc_release() return 0 Geert Uytterhoeven
@ 2014-04-07 19:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-04-07 19:08 UTC (permalink / raw)
To: geert; +Cc: jon.maloy, allan.stephens, netdev, tipc-discussion, linux-kernel
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Sun, 6 Apr 2014 15:56:14 +0200
> net/tipc/socket.c: In function ‘tipc_release’:
> net/tipc/socket.c:352: warning: ‘res’ is used uninitialized in this function
>
> Introduced by commit 24be34b5a0c9114541891d29dff1152bb1a8df34 ("tipc:
> eliminate upcall function pointers between port and socket"), which
> removed the sole initializer of "res".
>
> Just return 0 to fix it.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied, thanks a lot Geert.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-07 19:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-06 13:56 [PATCH] tipc: Let tipc_release() return 0 Geert Uytterhoeven
2014-04-07 19:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).