From: Joe Perches <joe@perches.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: gregkh@linuxfoundation.org, netdev@vger.kernel.org,
devel@driverdev.osuosl.org,
Jes Sorensen <Jes.Sorensen@redhat.com>,
kbuild-all@01.org
Subject: Re: [PATCH] staging: r8723au: Fix build warnings
Date: Wed, 09 Apr 2014 09:15:45 -0700 [thread overview]
Message-ID: <1397060145.14321.21.camel@joe-AO722> (raw)
In-Reply-To: <1397055920-11654-1-git-send-email-Larry.Finger@lwfinger.net>
On Wed, 2014-04-09 at 10:05 -0500, Larry Finger wrote:
> The kbuild test robot reports the following:
[]
> diff --git a/drivers/staging/rtl8723au/include/rtw_mlme.h b/drivers/staging/rtl8723au/include/rtw_mlme.h
[]
> -void rtw_set_roaming(struct rtw_adapter *adapter, u8 to_roaming);
> -u8 rtw_to_roaming(struct rtw_adapter *adapter);
> +inline void rtw_set_roaming(struct rtw_adapter *adapter, u8 to_roaming);
> +inline u8 rtw_to_roaming(struct rtw_adapter *adapter);
I think this doesn't make sense.
Either the inline should be removed from
the .c file or the function should be moved
into the .h file and made static inline.
next prev parent reply other threads:[~2014-04-09 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 15:05 [PATCH] staging: r8723au: Fix build warnings Larry Finger
2014-04-09 16:15 ` Joe Perches [this message]
2014-04-09 16:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397060145.14321.21.camel@joe-AO722 \
--to=joe@perches.com \
--cc=Jes.Sorensen@redhat.com \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).