* [PATCH 1/2] baycom_epp.c:#include <linux/uaccess.h>
@ 2014-04-09 23:25 Paul McQuade
2014-04-09 23:25 ` [PATCH 2/2] drivers:baycom_epp.c tabs Paul McQuade
0 siblings, 1 reply; 2+ messages in thread
From: Paul McQuade @ 2014-04-09 23:25 UTC (permalink / raw)
To: t.sailer; +Cc: linux-hams, netdev, linux-kernel
WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
---
drivers/net/hamradio/baycom_epp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hamradio/baycom_epp.c b/drivers/net/hamradio/baycom_epp.c
index 484f77e..3daafec 100644
--- a/drivers/net/hamradio/baycom_epp.c
+++ b/drivers/net/hamradio/baycom_epp.c
@@ -55,7 +55,7 @@
#include <linux/jiffies.h>
#include <linux/random.h>
#include <net/ax25.h>
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
/* --------------------------------------------------------------------- */
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] drivers:baycom_epp.c tabs
2014-04-09 23:25 [PATCH 1/2] baycom_epp.c:#include <linux/uaccess.h> Paul McQuade
@ 2014-04-09 23:25 ` Paul McQuade
0 siblings, 0 replies; 2+ messages in thread
From: Paul McQuade @ 2014-04-09 23:25 UTC (permalink / raw)
To: t.sailer; +Cc: linux-hams, netdev, linux-kernel
ERROR: code indent should use tabs where possible
ERROR: space required after that ';' (ctx:VxV)
Signed-off-by: Paul McQuade <paulmcquad@gmail.com>
---
drivers/net/hamradio/baycom_epp.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/net/hamradio/baycom_epp.c b/drivers/net/hamradio/baycom_epp.c
index 3daafec..5012ab5 100644
--- a/drivers/net/hamradio/baycom_epp.c
+++ b/drivers/net/hamradio/baycom_epp.c
@@ -54,7 +54,7 @@
#include <linux/baycom.h>
#include <linux/jiffies.h>
#include <linux/random.h>
-#include <net/ax25.h>
+#include <net/ax25.h>
#include <linux/uaccess.h>
/* --------------------------------------------------------------------- */
@@ -64,7 +64,7 @@
/* --------------------------------------------------------------------- */
-static const char paranoia_str[] = KERN_ERR
+static const char paranoia_str[] = KERN_ERR
"baycom_epp: bad magic number for hdlcdrv_state struct in routine %s\n";
static const char bc_drvname[] = "baycom_epp";
@@ -169,7 +169,7 @@ static struct net_device *baycom_device[NR_PORTS];
struct baycom_state {
int magic;
- struct pardevice *pdev;
+ struct pardevice *pdev;
struct net_device *dev;
unsigned int work_running;
struct delayed_work run_work;
@@ -185,18 +185,18 @@ struct baycom_state {
unsigned int loopback;
} cfg;
- struct hdlcdrv_channel_params ch_params;
+ struct hdlcdrv_channel_params ch_params;
- struct {
+ struct {
unsigned int bitbuf, bitstream, numbits, state;
unsigned char *bufptr;
int bufcnt;
unsigned char buf[TXBUFFER_SIZE];
- } hdlcrx;
+ } hdlcrx;
- struct {
+ struct {
int calibrate;
- int slotcnt;
+ int slotcnt;
int flags;
enum { tx_idle = 0, tx_keyup, tx_data, tx_tail } state;
unsigned char *bufptr;
@@ -246,9 +246,9 @@ struct baycom_state {
#if 0
static inline void append_crc_ccitt(unsigned char *buffer, int len)
{
- unsigned int crc = 0xffff;
+ unsigned int crc = 0xffff;
- for (;len>0;len--)
+ for ( ; len > 0; len--)
crc = (crc >> 8) ^ crc_ccitt_table[(crc ^ *buffer++) & 0xff];
crc ^= 0xffff;
*buffer++ = crc;
--
1.8.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-09 23:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-09 23:25 [PATCH 1/2] baycom_epp.c:#include <linux/uaccess.h> Paul McQuade
2014-04-09 23:25 ` [PATCH 2/2] drivers:baycom_epp.c tabs Paul McQuade
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).