From: Toshiaki Makita <toshiaki.makita1@gmail.com>
To: Dennis Punjabi <linuxdev@icts.bz>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: 802.1AD packets - Kernel changes ether type from 88A8 to 8100 on all packets.
Date: Sun, 13 Apr 2014 01:20:36 +0900 [thread overview]
Message-ID: <1397319636.1789.11.camel@localhost.localdomain> (raw)
In-Reply-To: <BLU184-W706F779E20884E4F486ED9D0540@phx.gbl>
1. On Fri, 2014-04-11 at 11:01 +0000, Dennis Punjabi wrote:
> Background:
> 1) I need to setup a Linux software bridge and ensure that packets coming in on one bridge port exit unchanged on another bridge port, like a normal HW bridge.
> 2) I need to use the new vlan filtering capability of the bridge. Good news of this feature is made in the kernel announcement of release 3.9 @ http://kernelnewbies.org/Linux_3.9
> 3) I need to test what presently happens to 802.1AD tagged packets when bridge vlan filtering is enabled because I also need support for Q-in-Q.
>
> I am using a packet generator (Ostinato) and creating 802.1AD packets as follows:
>
> (MAC_HDR) (8021AD_HDR) (8021Q HDR) (PAYLOAD)
>
> (DA | SA | TYPE) (TCI | TPID) (TCI | TPID) (TEST PAYLOAD - ARP BCAST PACKET)
>
> (DA | SA | 88A8) (TCI | 8100) (TCI | 0806) (TEST PAYLOAD - ARP BCAST PACKET)
>
> (hopefully the alignment is ok above, if not I apologize and hope its clear enough)
>
> Even before setting up the the bridge, I want to ensure that packets are being received properly to my system.
> I do a tcpdump output for the port receiving the generated packets.
>
> What I notice is that the 88A8 TPIC/ether type get changed to 8100.
> Ie, all packets with ether type 802.1AD get changed to 802.1Q type, ie 8100.
> I initially tested this on a 3.14 vanilla kernel.
Hi.
Though I'm not an expert with libpcap, I feel tcpdump sometimes shows a
wrong vlan protocol (if vlan_tci is used).
Maybe this topic has relevance?
packet: deliver VLAN TPID to userspace
http://marc.info/?l=linux-netdev&m=138728859001934&w=2
http://marc.info/?l=linux-netdev&m=138728859601935&w=2
http://marc.info/?l=linux-netdev&m=138728860101937&w=2
http://marc.info/?l=linux-netdev&m=138728860601939&w=2
Thanks,
Toshiaki Makita
>
> I recompiled my 8139too.c driver and printed printk the packets in the driver before they are handed over to netif_receive_skb.
> Before being passed to the kernel networking stack the packet is as it is supposed to be, ie it has the correct 88A8 ether type.
>
> I went ahead and tested this on kernel 3.12, 3.11, 3.10. I Saw the same result.
>
> I also tested it on 3.9, 3.8 and 2.6 and these kernels did not change the 88A8 to 8100.
>
> Is this intentional or a bug? Does this have something to do with the addition of the new feature (vlan: Add 802.1ad support) announced in kernel 3.10? http://kernelnewbies.org/Linux_3.10
>
> I have been following the net-dev mailing lists and want to test the bridge 802.1AD filtering feature discussed here http://www.spinics.net/lists/linux-ethernet-bridging/msg05207.html but cannot do so if the bridge does not even get the 802.1AD tagged packets to begin with.
>
> Assuming I don't want to use filtering and just want a simple bridge. The expected behaviour is that the bridge must not change my packet and should simply pass it along. Is my thinking correct?
>
> Thanks for any help provided.
>
> Dennis
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-12 16:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 11:01 802.1AD packets - Kernel changes ether type from 88A8 to 8100 on all packets Dennis Punjabi
2014-04-12 16:20 ` Toshiaki Makita [this message]
2014-04-12 17:06 ` Daniel Borkmann
2014-04-14 4:45 ` Atzm Watanabe
2014-04-15 1:34 ` Dennis Punjabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397319636.1789.11.camel@localhost.localdomain \
--to=toshiaki.makita1@gmail.com \
--cc=linuxdev@icts.bz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).