netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
To: <netdev@vger.kernel.org>
Cc: <Dept-HSGLinuxNICDev@qlogic.com>, <ben@decadent.org.uk>,
	<gregory.v.rose@intel.com>, <linux-net-drivers@solarflare.com>,
	<Ariel.Elior@qlogic.com>, <amirv@mellanox.com>,
	<mkubecek@suse.cz>
Subject: [RFC v3 0/1]: Add minimum bandwidth support in IP tool.
Date: Mon, 14 Apr 2014 00:36:09 -0400	[thread overview]
Message-ID: <1397450170-8221-1-git-send-email-sucheta.chakraborty@qlogic.com> (raw)

Today IP tool allows configuring only maximum bandwidth.
Likewise minimum bandwidth can also be configured for a VF. It puts
lower limit on the VF bandwidth. VF is guaranteed to have a bandwidth
of at least this value.

With this change, user can alter minimum bandwidth rate.

This patch series has 1 combined patch that adds required support in kernel
and qlcnic driver changes for minimum bandwidth support.

This change also requires changes in IP tool. I am sending that patch
separately.

Changes in v2 per suggestions from Ben Hutchings and Michal Kubecek:

   net patch:
        o Fixed enum index for IFLA_VF_RATE
        o ndo_set_vf_rate replaces ndo_set_vf_tx_rate. Drivers that currently implement
          ndo_set_vf_tx_rate is converted to implement ndo_set_vf_rate instead.
        o If only IFLA_VF_TX_RATE is specified, the core should get the current minimum
          before calling ndo_set_vf_rate.
        o IFLA_VF_RATE should override if both IFLA_VF_RATE and IFLA_VF_TX_RATE are specified.
        o Combined qlcnic patch to add support for minimum bandwidth with net patch

Changes in v3 as per suggestions from Ben Hutchings

    net patch:
        o If user enters only one value out of min_tx_rate or max_tx_rate, the other
          value will be read back in userspace for IFLA_VF_RATE.

        o For IFLA_VF_TX_RATE, min rate will still be read in kernel space to preserve
          compatibility:
          (a) between old tool sends "rate" and kernel is new (expects "min" and "max")
          (b) or, when new tool sends only "rate" and kernel is old (expects only "rate")

Please comment.

Thanks,
Sucheta.

Sucheta Chakraborty (1):
  net: Add support to configure SR-IOV VF minimum and maximum Tx
    rate through ip tool.

 drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c  |    3 +-
 drivers/net/ethernet/emulex/benet/be_main.c        |   20 +++++---
 drivers/net/ethernet/intel/i40e/i40e_main.c        |    2 +-
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c |    6 ++-
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.h |    3 +-
 drivers/net/ethernet/intel/igb/igb_main.c          |   20 +++++---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c      |    2 +-
 drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c     |   13 +++--
 drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.h     |    3 +-
 drivers/net/ethernet/mellanox/mlx4/cmd.c           |   11 ++--
 drivers/net/ethernet/qlogic/qlcnic/qlcnic.h        |    1 +
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c   |    2 +-
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov.h  |    2 +-
 .../ethernet/qlogic/qlcnic/qlcnic_sriov_common.c   |    1 +
 .../net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c   |   52 ++++++++++++++------
 drivers/net/ethernet/sfc/siena_sriov.c             |    3 +-
 include/linux/if_link.h                            |    3 +-
 include/linux/netdevice.h                          |    8 ++-
 include/uapi/linux/if_link.h                       |    9 +++-
 net/core/rtnetlink.c                               |   38 ++++++++++++--
 20 files changed, 142 insertions(+), 60 deletions(-)

             reply	other threads:[~2014-04-14  5:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-14  4:36 Sucheta Chakraborty [this message]
2014-04-14  4:36 ` [PATCH] net:v3: Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool Sucheta Chakraborty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397450170-8221-1-git-send-email-sucheta.chakraborty@qlogic.com \
    --to=sucheta.chakraborty@qlogic.com \
    --cc=Ariel.Elior@qlogic.com \
    --cc=Dept-HSGLinuxNICDev@qlogic.com \
    --cc=amirv@mellanox.com \
    --cc=ben@decadent.org.uk \
    --cc=gregory.v.rose@intel.com \
    --cc=linux-net-drivers@solarflare.com \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).