netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vincenzo Maffione <v.maffione@gmail.com>
To: konrad.wilk@oracle.com
Cc: boris.ostrovsky@oracle.com, david.vrabel@citrix.com,
	xen-devel@lists.xenproject.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Vincenzo Maffione <v.maffione@gmail.com>
Subject: [PATCH] drivers: net: xen-netfront: remove unused arrays
Date: Tue, 15 Apr 2014 19:39:39 +0200	[thread overview]
Message-ID: <1397583579-32162-1-git-send-email-v.maffione@gmail.com> (raw)

This patch removes some unused arrays from the netfront
private data structure.
Also removes an unused address variable.

Signed-off-by: Vincenzo Maffione <v.maffione@gmail.com>
---
Hello,
  I don't see the point in having those unused arrays in the private
structure.

Sorry if I'm missing something.

Cheers,
  Vincenzo


 drivers/net/xen-netfront.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 158b5e6..1403ac7 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -137,10 +137,6 @@ struct netfront_info {
 	grant_ref_t gref_rx_head;
 	grant_ref_t grant_rx_ref[NET_RX_RING_SIZE];
 
-	unsigned long rx_pfn_array[NET_RX_RING_SIZE];
-	struct multicall_entry rx_mcl[NET_RX_RING_SIZE+1];
-	struct mmu_update rx_mmu[NET_RX_RING_SIZE];
-
 	/* Statistics */
 	struct netfront_stats __percpu *stats;
 
@@ -252,7 +248,6 @@ static void xennet_alloc_rx_buffers(struct net_device *dev)
 	RING_IDX req_prod = np->rx.req_prod_pvt;
 	grant_ref_t ref;
 	unsigned long pfn;
-	void *vaddr;
 	struct xen_netif_rx_request *req;
 
 	if (unlikely(!netif_carrier_ok(dev)))
@@ -322,7 +317,6 @@ no_skb:
 		np->grant_rx_ref[id] = ref;
 
 		pfn = page_to_pfn(skb_frag_page(&skb_shinfo(skb)->frags[0]));
-		vaddr = page_address(skb_frag_page(&skb_shinfo(skb)->frags[0]));
 
 		req = RING_GET_REQUEST(&np->rx, req_prod + i);
 		gnttab_grant_foreign_access_ref(ref,
-- 
1.9.2

             reply	other threads:[~2014-04-15 17:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-15 17:39 Vincenzo Maffione [this message]
2014-04-15 17:54 ` [PATCH] drivers: net: xen-netfront: remove unused arrays David Vrabel
2014-04-15 18:46   ` Vincenzo Maffione
2014-04-16  8:26   ` [Xen-devel] " Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397583579-32162-1-git-send-email-v.maffione@gmail.com \
    --to=v.maffione@gmail.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).