From: Thor Thayer <tthayer@altera.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: <linux-can@vger.kernel.org>, <wg@grandegger.com>,
<mkl@pengutronix.de>, <socketcan@hartkopp.net>,
<anilkumar@ti.com>, <tthayer.linux@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: c_can: Add support for D_CAN module RAM Init.
Date: Thu, 17 Apr 2014 09:36:55 -0500 [thread overview]
Message-ID: <1397745415.31413.2.camel@dinh-ubuntu> (raw)
In-Reply-To: <alpine.DEB.2.02.1404162312020.22697@ionos.tec.linutronix.de>
On Wed, 2014-04-16 at 23:13 +0200, Thomas Gleixner wrote:
>
> On Wed, 16 Apr 2014, tthayer@altera.com wrote:
>
> > From: Thor Thayer <tthayer@altera.com>
> >
> > The D_CAN driver was written to support the TI D_CAN implementation
> > which placed the D_CAN RAM reset in a separate register. In the
> > standard D_CAN module the RAM Init is in the D_CAN module so
> > handle the RAM Init differently.
> > + if (!res) {
> > + priv->raminit = c_can_hw_raminit;
> > + priv->raminit_type_flag = 0;
>
> Can we please make that raminit_type and use proper constants?
>
> Thanks,
>
> tglx
Yes. I will make these changes. Thanks for reviewing.
prev parent reply other threads:[~2014-04-17 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1397672973-3480-1-git-send-email-tthayer@altera.com>
2014-04-16 18:29 ` [PATCH] net: c_can: Add support for D_CAN module RAM Init tthayer
2014-04-16 21:13 ` Thomas Gleixner
2014-04-17 14:36 ` Thor Thayer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1397745415.31413.2.camel@dinh-ubuntu \
--to=tthayer@altera.com \
--cc=anilkumar@ti.com \
--cc=davem@davemloft.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=tglx@linutronix.de \
--cc=tthayer.linux@gmail.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).