From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] smc91x: fix compile error when SMC_DEBUG >= 2 Date: Fri, 18 Apr 2014 21:06:53 -0700 Message-ID: <1397880413.3106.2.camel@joe-AO725> References: <1397879250-32041-1-git-send-email-zlim.lnx@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Nicolas Pitre , netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Zi Shen Lim Return-path: In-Reply-To: <1397879250-32041-1-git-send-email-zlim.lnx@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, 2014-04-18 at 20:47 -0700, Zi Shen Lim wrote: > When SMC_DEBUG >=3D 2, we hit the following compilation error: >=20 > drivers/net/ethernet/smsc/smc91x.c:85:0: > drivers/net/ethernet/smsc/smc91x.c: In function =E2=80=98smc_findirq=E2= =80=99: > drivers/net/ethernet/smsc/smc91x.c:1784:9: error: =E2=80=98dev=E2=80=99= undeclared (first use in this function) > DBG(2, dev, "%s: %s\n", CARDNAME, __func__); > ^ > Fix it by passing in the appropriate netdev pointer. Perhaps verifying the format and args in all cases would help avoid more of these in the future. --- drivers/net/ethernet/smsc/smc91x.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/= smsc/smc91x.c index d1b4dca..a8302f5 100644 --- a/drivers/net/ethernet/smsc/smc91x.c +++ b/drivers/net/ethernet/smsc/smc91x.c @@ -148,16 +148,19 @@ MODULE_ALIAS("platform:smc91x"); #define MII_DELAY 1 =20 #if SMC_DEBUG > 0 -#define DBG(n, dev, args...) \ - do { \ - if (SMC_DEBUG >=3D (n)) \ - netdev_dbg(dev, args); \ - } while (0) - -#define PRINTK(dev, args...) netdev_info(dev, args) +#define DBG(n, dev, fmt, ...) \ +do { \ + if (SMC_DEBUG >=3D (n)) \ + netdev_dbg(dev, fmt, ##__VA_ARGS__); \ +} while (0) +#define PRINTK(dev, fmt, ...) netdev_info(dev, fmt, ##__VA_ARGS__) #else -#define DBG(n, dev, args...) do { } while (0) -#define PRINTK(dev, args...) netdev_dbg(dev, args) +#define DBG(n, dev, fmt, ...) \ +do { \ + if (0) \ + netdev_dbg(dev, fmt, ##__VA_ARGS__); \ +} while (0) +#define PRINTK(dev, fmt, ...) netdev_dbg(dev, fmt, ##__VA_ARGS__) #endif =20 #if SMC_DEBUG > 3 @@ -191,7 +194,9 @@ static void PRINT_PKT(u_char *buf, int length) pr_cont("\n"); } #else -#define PRINT_PKT(x...) do { } while (0) +static inline void PRINT_PKT(u_char *buf, int length) +{ +} #endif =20 =20