netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH net-next 4/4] net: bcmgenet: do not set RX buffer length
Date: Mon, 21 Apr 2014 08:45:24 -0700	[thread overview]
Message-ID: <1398095124-5411-5-git-send-email-f.fainelli@gmail.com> (raw)
In-Reply-To: <1398095124-5411-1-git-send-email-f.fainelli@gmail.com>

There is no need to set the buffer length during RX buffer allocation
since the hardware will fill that information when the packet is
received, so we are basically forcing a value that will get overwritten.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
index 4922958ec4aa..e15411431c9b 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
@@ -1479,13 +1479,6 @@ static int bcmgenet_alloc_rx_buffers(struct bcmgenet_priv *priv)
 		if (cb->skb)
 			continue;
 
-		/* set the DMA descriptor length once and for all
-		 * it will only change if we support dynamically sizing
-		 * priv->rx_buf_len, but we do not
-		 */
-		dmadesc_set_length_status(priv, priv->rx_bd_assign_ptr,
-				priv->rx_buf_len << DMA_BUFLENGTH_SHIFT);
-
 		ret = bcmgenet_rx_refill(priv, cb);
 		if (ret)
 			break;
-- 
1.9.1

      parent reply	other threads:[~2014-04-21 15:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-21 15:45 [PATCH net-next 0/4] net: bcmgenet: interrupt coalescing support Florian Fainelli
2014-04-21 15:45 ` [PATCH net-next 1/4] net: bcmgenet: prepare for MBDONE interrupts support Florian Fainelli
2014-04-21 15:45 ` [PATCH net-next 2/4] net: bcmgenet: add support for ethtool tx-frames Florian Fainelli
2014-04-21 19:17   ` David Miller
2014-04-21 19:55     ` Florian Fainelli
2014-04-21 19:59       ` David Miller
2014-04-21 15:45 ` [PATCH net-next 3/4] net: bcmgenet: add support for ethtool rx-frames Florian Fainelli
2014-04-21 15:45 ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398095124-5411-5-git-send-email-f.fainelli@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).