From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, bh74.an@samsung.com, ks.giri@samsung.com,
siva.kallam@samsung.com, peppe.cavallaro@st.com,
jcmvbkbc@gmail.com, Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH net-next 1/4] net: ethoc: remove ethoc_config
Date: Mon, 21 Apr 2014 09:09:19 -0700 [thread overview]
Message-ID: <1398096563-8786-2-git-send-email-f.fainelli@gmail.com> (raw)
In-Reply-To: <1398096563-8786-1-git-send-email-f.fainelli@gmail.com>
ethoc_config() returns -ENOSYS and does not implement anything useful,
let's remove it such that net/core/dev_ioctl.c::dev_ifsioc can return
something meaningful like -EOPNOTSUPP.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/ethoc.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c
index 8b70ca7e342b..f3658bdb64cc 100644
--- a/drivers/net/ethernet/ethoc.c
+++ b/drivers/net/ethernet/ethoc.c
@@ -769,11 +769,6 @@ static int ethoc_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
return phy_mii_ioctl(phy, ifr, cmd);
}
-static int ethoc_config(struct net_device *dev, struct ifmap *map)
-{
- return -ENOSYS;
-}
-
static void ethoc_do_set_mac_address(struct net_device *dev)
{
struct ethoc *priv = netdev_priv(dev);
@@ -995,7 +990,6 @@ static const struct net_device_ops ethoc_netdev_ops = {
.ndo_open = ethoc_open,
.ndo_stop = ethoc_stop,
.ndo_do_ioctl = ethoc_ioctl,
- .ndo_set_config = ethoc_config,
.ndo_set_mac_address = ethoc_set_mac_address,
.ndo_set_rx_mode = ethoc_set_multicast_list,
.ndo_change_mtu = ethoc_change_mtu,
--
1.9.1
next prev parent reply other threads:[~2014-04-21 16:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 16:09 [PATCH net-next 0/4] net: ndo_set_config/ifmap cleanups Florian Fainelli
2014-04-21 16:09 ` Florian Fainelli [this message]
2014-04-21 17:43 ` [PATCH net-next 1/4] net: ethoc: remove ethoc_config Max Filippov
2014-04-21 16:09 ` [PATCH net-next 2/4] net: cpmac: remove cpmac_config Florian Fainelli
2014-04-21 16:09 ` [PATCH net-next 3/4] net: sxgbe: remove sxgbe_config Florian Fainelli
2014-04-21 16:09 ` [PATCH net-next 4/4] stmmac: remove stmmac_config Florian Fainelli
2014-04-21 18:59 ` [PATCH net-next 0/4] net: ndo_set_config/ifmap cleanups David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398096563-8786-2-git-send-email-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bh74.an@samsung.com \
--cc=davem@davemloft.net \
--cc=jcmvbkbc@gmail.com \
--cc=ks.giri@samsung.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=siva.kallam@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).