netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adam Lee <adam.lee@canonical.com>
To: linux-wireless@vger.kernel.org
Cc: netdev@vger.kernel.org, Larry Finger <Larry.Finger@lwfinger.net>,
	"John W. Linville" <linville@tuxdriver.com>
Subject: [PATCH 1/2] Revert "rtlwifi: rtl8188ee: enable MSI interrupts mode"
Date: Thu, 24 Apr 2014 11:08:43 +0800	[thread overview]
Message-ID: <1398308924-15312-1-git-send-email-adam.lee@canonical.com> (raw)

This reverts commit 2a54eb5e1476426ee639bbfbe179b52342a0d82c.

94010fa0dd07e8b904e7c6b6589f15573008ab15 introduced MSI interrupts mode
support, which seemed safe enough with RTL8188EE and RTL8723BE as
RealTek's testing results, but some users reported their RTL8188EE
modules could not connect to any wireless network after the MSI mode was
enabled by Ubuntu 14.04.

So, let's fallback to pin-based mode until rtlwifi's MSI support get
good compatibility.

BugLink: https://bugs.launchpad.net/bugs/1310512
Signed-off-by: Adam Lee <adam.lee@canonical.com>
---
 drivers/net/wireless/rtlwifi/rtl8188ee/sw.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c b/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c
index 1b4101b..347af1e 100644
--- a/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c
@@ -93,7 +93,6 @@ int rtl88e_init_sw_vars(struct ieee80211_hw *hw)
 	u8 tid;
 
 	rtl8188ee_bt_reg_init(hw);
-	rtlpci->msi_support = true;
 
 	rtlpriv->dm.dm_initialgain_enable = 1;
 	rtlpriv->dm.dm_flag = 0;
-- 
2.0.0.rc0

             reply	other threads:[~2014-04-24  3:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24  3:08 Adam Lee [this message]
2014-04-24  3:08 ` [PATCH 2/2] rtlwifi: rtl8723be: disable MSI interrupts mode Adam Lee
2014-04-24 12:10   ` Sergei Shtylyov
2014-04-24  6:25 ` [PATCH 1/2] Revert "rtlwifi: rtl8188ee: enable MSI interrupts mode" Larry Finger
2014-04-24 12:04 ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398308924-15312-1-git-send-email-adam.lee@canonical.com \
    --to=adam.lee@canonical.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).