[PATCH 1/2] Revert "rtlwifi: rtl8188ee: enable MSI interrupts mode"

[PATCH 1/2] Revert "rtlwifi: rtl8188ee: enable MSI interrupts mode"

[Adam Lee]

This reverts commit 2a54eb5e1476426ee639bbfbe179b52342a0d82c.

94010fa0dd07e8b904e7c6b6589f15573008ab15 introduced MSI interrupts mode
support, which seemed safe enough with RTL8188EE and RTL8723BE as
RealTek's testing results, but some users reported their RTL8188EE
modules could not connect to any wireless network after the MSI mode was
enabled by Ubuntu 14.04.

So, let's fallback to pin-based mode until rtlwifi's MSI support get
good compatibility.

BugLink: https://bugs.launchpad.net/bugs/1310512
Signed-off-by: Adam Lee <adam.lee@canonical.com>
---
 drivers/net/wireless/rtlwifi/rtl8188ee/sw.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c b/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c
index 1b4101b..347af1e 100644
--- a/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c
@@ -93,7 +93,6 @@ int rtl88e_init_sw_vars(struct ieee80211_hw *hw)
 	u8 tid;
 
 	rtl8188ee_bt_reg_init(hw);
-	rtlpci->msi_support = true;
 
 	rtlpriv->dm.dm_initialgain_enable = 1;
 	rtlpriv->dm.dm_flag = 0;
-- 
2.0.0.rc0

[PATCH 2/2] rtlwifi: rtl8723be: disable MSI interrupts mode

[Adam Lee]

94010fa0dd07e8b904e7c6b6589f15573008ab15 introduced MSI interrupts mode
support, which seemed safe enough with RTL8188EE and RTL8723BE as
RealTek's testing results, but some users reported their RTL8188EE
modules could not connect to any wireless network after the MSI mode was
enabled by Ubuntu 14.04.

So, let's fallback to pin-based mode until rtlwifi's MSI support get
good compatibility.

BugLink: https://bugs.launchpad.net/bugs/1310512
Signed-off-by: Adam Lee <adam.lee@canonical.com>
---
 drivers/net/wireless/rtlwifi/rtl8723be/sw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8723be/sw.c b/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
index b4577eb..a072136 100644
--- a/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8723be/sw.c
@@ -92,7 +92,7 @@ int rtl8723be_init_sw_vars(struct ieee80211_hw *hw)
 	struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
 
 	rtl8723be_bt_reg_init(hw);
-	rtlpci->msi_support = true;
+	rtlpci->msi_support = false;
 	rtlpriv->btcoexist.btc_ops = rtl_btc_get_ops_pointer();
 
 	rtlpriv->dm.dm_initialgain_enable = 1;
-- 
2.0.0.rc0

Re: [PATCH 2/2] rtlwifi: rtl8723be: disable MSI interrupts mode

[Sergei Shtylyov]

On 24-04-2014 7:08, Adam Lee wrote:

> 94010fa0dd07e8b904e7c6b6589f15573008ab15 introduced MSI interrupts mode

    Please also specify that commit's summary line in parens.

> support, which seemed safe enough with RTL8188EE and RTL8723BE as
> RealTek's testing results, but some users reported their RTL8188EE
> modules could not connect to any wireless network after the MSI mode was
> enabled by Ubuntu 14.04.

> So, let's fallback to pin-based mode until rtlwifi's MSI support get
> good compatibility.

> BugLink: https://bugs.launchpad.net/bugs/1310512
> Signed-off-by: Adam Lee <adam.lee@canonical.com>

WBR, Sergei

Re: [PATCH 1/2] Revert "rtlwifi: rtl8188ee: enable MSI interrupts mode"

[Larry Finger]

On 04/23/2014 10:08 PM, Adam Lee wrote:
> This reverts commit 2a54eb5e1476426ee639bbfbe179b52342a0d82c.
>
> 94010fa0dd07e8b904e7c6b6589f15573008ab15 introduced MSI interrupts mode
> support, which seemed safe enough with RTL8188EE and RTL8723BE as
> RealTek's testing results, but some users reported their RTL8188EE
> modules could not connect to any wireless network after the MSI mode was
> enabled by Ubuntu 14.04.
>
> So, let's fallback to pin-based mode until rtlwifi's MSI support get
> good compatibility.
>
> BugLink: https://bugs.launchpad.net/bugs/1310512
> Signed-off-by: Adam Lee <adam.lee@canonical.com>

ACK for both of these patches. I thought I had tested these patches when they 
first came through, but obviously I did not. I do not know which Realtek 
engineers you consulted, but they failed to supply you with the MSI handler. The 
Realsil group that actually does the coding for the PCI-based devices have 
supplied such a routine along with the driver for the RTL8192EE devices. With 
the handler, MSI does work. After I integrate that handler into rtlwifi, I will 
resubmit the patches turning on MSI for rtl8188ee and rtl8723ae.

Larry

> ---
>   drivers/net/wireless/rtlwifi/rtl8188ee/sw.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c b/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c
> index 1b4101b..347af1e 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8188ee/sw.c
> @@ -93,7 +93,6 @@ int rtl88e_init_sw_vars(struct ieee80211_hw *hw)
>   	u8 tid;
>
>   	rtl8188ee_bt_reg_init(hw);
> -	rtlpci->msi_support = true;
>
>   	rtlpriv->dm.dm_initialgain_enable = 1;
>   	rtlpriv->dm.dm_flag = 0;
>

Re: [PATCH 1/2] Revert "rtlwifi: rtl8188ee: enable MSI interrupts mode"

[Sergei Shtylyov]

Hello.

On 24-04-2014 7:08, Adam Lee wrote:

> This reverts commit 2a54eb5e1476426ee639bbfbe179b52342a0d82c.

> 94010fa0dd07e8b904e7c6b6589f15573008ab15 introduced MSI interrupts mode

    Please also specify that commit's summary line in parens.

> support, which seemed safe enough with RTL8188EE and RTL8723BE as
> RealTek's testing results, but some users reported their RTL8188EE
> modules could not connect to any wireless network after the MSI mode was
> enabled by Ubuntu 14.04.

> So, let's fallback to pin-based mode until rtlwifi's MSI support get
> good compatibility.

> BugLink: https://bugs.launchpad.net/bugs/1310512
> Signed-off-by: Adam Lee <adam.lee@canonical.com>

WBR, Sergei