From: xiao jin <jin.xiao@intel.com>
To: davem@davemloft.net, trivial@kernel.org, ebiederm@xmission.com,
dhowells@redhat.com, viro@zeniv.linux.org.uk,
serge.hallyn@canonical.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: david.a.cohen@linux.intel.com, xiao jin <jin.xiao@intel.com>
Subject: [PATCH] cleanup_net: trivial cleanup
Date: Fri, 25 Apr 2014 08:50:54 +0800 [thread overview]
Message-ID: <1398387054-11172-1-git-send-email-jin.xiao@intel.com> (raw)
Do not initialize net_kill_list twice.
list_replace_init() already takes care of initializing net_kill_list.
We don't need to initialize it with LIST_HEAD() beforehand.
Signed-off-by: xiao jin <jin.xiao@intel.com>
Reviewed-by: David Cohen <david.a.cohen@linux.intel.com>
---
net/core/net_namespace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c
index 81d3a9a..05e949d 100644
--- a/net/core/net_namespace.c
+++ b/net/core/net_namespace.c
@@ -273,7 +273,7 @@ static void cleanup_net(struct work_struct *work)
{
const struct pernet_operations *ops;
struct net *net, *tmp;
- LIST_HEAD(net_kill_list);
+ struct list_head net_kill_list;
LIST_HEAD(net_exit_list);
/* Atomically snapshot the list of namespaces to cleanup */
--
1.7.9.5
next reply other threads:[~2014-04-25 0:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 0:50 xiao jin [this message]
2014-04-26 16:52 ` [PATCH] cleanup_net: trivial cleanup David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398387054-11172-1-git-send-email-jin.xiao@intel.com \
--to=jin.xiao@intel.com \
--cc=davem@davemloft.net \
--cc=david.a.cohen@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
--cc=trivial@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).