From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toshiaki Makita Subject: Re: [PATCH net] bridge: Handle IFLA_ADDRESS correctly when creating bridge device Date: Fri, 25 Apr 2014 17:18:45 +0900 Message-ID: <1398413925.3920.15.camel@ubuntu-vm-makita> References: <1398341177.4171.11.camel@ubuntu-vm-makita> <1398341787.4171.16.camel@ubuntu-vm-makita> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Stephen Hemminger , netdev , bridge , "David S. Miller" , "C. R. Oldham" To: Tom Gundersen Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Thu, 2014-04-24 at 18:04 +0200, Tom Gundersen wrote: > On Thu, Apr 24, 2014 at 2:16 PM, Toshiaki Makita > wrote: > > When bridge device is created with IFLA_ADDRESS, we are not calling > > br_stp_change_bridge_id(), which leads to incorrect local fdb > > management and bridge id calculation, and prevents us from receiving > > frames on the bridge device. > > > > Reported-by: Tom Gundersen > > Thanks. That looks correct to me (not able to test at the moment > though). Would this be appropriate for stable if it goes in? This can apply 3.14 as is. For 3.12 or earlier tree, this needs modification to insert the fdb entry (or backport fdb fix patchset (684bd2e1)). And for 3.2, another patch needs to be backported before this because br_fdb_change_mac_address() doesn't exist. Thanks, Toshiaki Makita