From: Maxime Bizon <mbizon@freebox.fr>
To: Patrick McHardy <kaber@trash.net>
Cc: Eric Dumazet <edumazet@google.com>,
davem@davemloft.net, netdev <netdev@vger.kernel.org>
Subject: Re: problem forwarding IP fragments with DF bit set (caused by ipv4: fix path MTU discovery with connection tracking)
Date: Mon, 28 Apr 2014 19:59:40 +0200 [thread overview]
Message-ID: <1398707980.10880.6.camel@sakura.staff.proxad.net> (raw)
In-Reply-To: <1398703056.12635.41.camel@sakura.staff.proxad.net>
On Mon, 2014-04-28 at 18:37 +0200, Maxime Bizon wrote:
>
> conntrack causes the packets to be re-assembled, but since the
> resulting skb now has IP_DF set, it fails the (DF + MTU) test in
> ip_forward.c and causes ICMP frag_needed to be sent.
hum isn't it just a matter of doing this ?
--- a/net/ipv4/ip_fragment.c
+++ b/net/ipv4/ip_fragment.c
@@ -493,6 +493,8 @@ found:
skb->len + ihl > qp->q.max_size)
qp->q.max_size = skb->len + ihl;
+ skb->local_df = 1;
+
if (qp->q.last_in == (INET_FRAG_FIRST_IN | INET_FRAG_LAST_IN) &&
qp->q.meat == qp->q.len) {
unsigned long orefdst = skb->_skb_refdst;
--
Maxime
next prev parent reply other threads:[~2014-04-28 19:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 16:37 problem forwarding IP fragments with DF bit set (caused by ipv4: fix path MTU discovery with connection tracking) Maxime Bizon
2014-04-28 17:59 ` Maxime Bizon [this message]
2014-04-29 14:35 ` Patrick McHardy
2014-04-29 14:33 ` Patrick McHardy
2014-04-29 14:42 ` Maxime Bizon
2014-04-29 14:45 ` Patrick McHardy
2014-04-29 15:23 ` Maxime Bizon
2014-04-29 15:37 ` Eric Dumazet
2014-04-29 20:13 ` Florian Westphal
2014-04-30 14:34 ` Maxime Bizon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398707980.10880.6.camel@sakura.staff.proxad.net \
--to=mbizon@freebox.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).