From: Vlad Yasevich <vyasevic@redhat.com>
To: netdev@vger.kernel.org
Cc: daniel.lezcano@free.fr, nightnord@gmail.com, kaber@trash.net,
eric.dumazet@gmail.com, mst@redhat.com, jasowang@redhat.com,
Vlad Yasevich <vyasevic@redhat.com>
Subject: [PATCH v2 net 0/2] Fix macvtap checksum errors in bridge mode
Date: Tue, 29 Apr 2014 10:09:49 -0400 [thread overview]
Message-ID: <1398780591-10644-1-git-send-email-vyasevic@redhat.com> (raw)
The following is a problematic configuration:
VM1: virtio-net device connected to macvtap0@eth0
VM2: e1000 device connect to macvtap1@eth0
The problem is is that virtio-net supports checksum offloading
and thus sends the packets to the host with CHECKSUM_PARTIAL set.
On the other hand, e1000 does not support any acceleration.
For small TCP packets (and this includes the 3-way handshake),
e1000 end up receiving packets that only have a partial checksum
set. This causes TCP to fail checksum validation and to drop
packets. As a result tcp connections can not be established.
The following 2 patches resolve this issue. The first patch adds
a check to the non-gso code path to see if the checksum needs to
be computed. The second patch reverts an old commit that set
ip_summed to CHECKSUM_UNNECESSARY. Proper checksum update is
necessary under certain circumstances.
I wend through the old thread
http://comments.gmane.org/gmane.linux.kernel.containers.lxc.general/1459
and tried the reproducers listed there, but could not cause
invalid checksum to trigger with this series.
Daniel and Andrian, if you have the time please try this patch
set to see if you still see the old checksum issues.
v1->v2: Updated comment from MST.
Vlad Yasevich (2):
mactap: Fix checksum errors for non-gso packets in bridge mode
Revert "macvlan : fix checksums error when we are in bridge mode"
drivers/net/macvlan.c | 3 ---
drivers/net/macvtap.c | 9 +++++++++
2 files changed, 9 insertions(+), 3 deletions(-)
--
1.9.0
next reply other threads:[~2014-04-29 14:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 14:09 Vlad Yasevich [this message]
2014-04-29 14:09 ` [PATCH v2 net 1/2] mactap: Fix checksum errors for non-gso packets in bridge mode Vlad Yasevich
2014-04-29 13:21 ` Michael S. Tsirkin
2014-04-30 2:46 ` Jason Wang
2014-04-29 14:09 ` [PATCH v2 net 2/2] Revert "macvlan : fix checksums error when we are in bridge mode" Vlad Yasevich
2014-04-29 13:22 ` Michael S. Tsirkin
2014-04-30 2:47 ` Jason Wang
2014-04-30 20:15 ` [PATCH v2 net 0/2] Fix macvtap checksum errors in bridge mode David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398780591-10644-1-git-send-email-vyasevic@redhat.com \
--to=vyasevic@redhat.com \
--cc=daniel.lezcano@free.fr \
--cc=eric.dumazet@gmail.com \
--cc=jasowang@redhat.com \
--cc=kaber@trash.net \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nightnord@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).