From: Vlad Yasevich <vyasevic@redhat.com>
To: netdev@vger.kernel.org
Cc: bridge@lists.linux-foundation.org, shemminger@vyatta.com,
jhs@mojatatu.com, john.r.fastabend@intel.com, mst@redhat.com,
Vlad Yasevich <vyasevic@redhat.com>
Subject: [RFC PATCH v2 net-next 3/7] bridge: Add functionality to sync static fdb entries to hw
Date: Tue, 29 Apr 2014 17:20:24 -0400 [thread overview]
Message-ID: <1398806428-640-4-git-send-email-vyasevic@redhat.com> (raw)
In-Reply-To: <1398806428-640-1-git-send-email-vyasevic@redhat.com>
Add code that allows static fdb entires to be synced to the
hw list for a specified port. This will be used later to
program ports that can function in non-promiscous mode.
Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
---
net/bridge/br_fdb.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++
net/bridge/br_private.h | 2 ++
2 files changed, 58 insertions(+)
diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index 9203d5a..9759b61 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -874,3 +874,59 @@ int br_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[],
out:
return err;
}
+
+int br_fdb_sync_static(struct net_bridge *br, struct net_bridge_port *p)
+{
+ struct net_bridge_fdb_entry *fdb, *tmp = NULL;
+ int i;
+ int err = 0;
+
+ ASSERT_RTNL();
+
+ for (i = 0; i < BR_HASH_SIZE; i++) {
+ hlist_for_each_entry(fdb, &br->hash[i], hlist) {
+ /* We only care for static entries */
+ if (!fdb->is_static)
+ continue;
+
+ err = dev_uc_add(p->dev, fdb->addr.addr);
+ if (err)
+ goto rollback;
+ }
+ }
+ return 0;
+
+rollback:
+ for (i = 0; i < BR_HASH_SIZE; i++) {
+ hlist_for_each_entry(tmp, &br->hash[i], hlist) {
+ /* If we reached the fdb that failed, we can stop */
+ if (tmp == fdb)
+ break;
+
+ /* We only care for static entries */
+ if (!tmp->is_static)
+ continue;
+
+ dev_uc_del(p->dev, tmp->addr.addr);
+ }
+ }
+ return err;
+}
+
+void br_fdb_unsync_static(struct net_bridge *br, struct net_bridge_port *p)
+{
+ struct net_bridge_fdb_entry *fdb;
+ int i;
+
+ ASSERT_RTNL();
+
+ for (i = 0; i < BR_HASH_SIZE; i++) {
+ hlist_for_each_entry_rcu(fdb, &br->hash[i], hlist) {
+ /* We only care for static entries */
+ if (!fdb->is_static)
+ continue;
+
+ dev_uc_del(p->dev, fdb->addr.addr);
+ }
+ }
+}
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index db714a1..2023671 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -399,6 +399,8 @@ int br_fdb_add(struct ndmsg *nlh, struct nlattr *tb[], struct net_device *dev,
const unsigned char *addr, u16 nlh_flags);
int br_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb,
struct net_device *dev, int idx);
+int br_fdb_sync_static(struct net_bridge *br, struct net_bridge_port *p);
+void br_fdb_unsync_static(struct net_bridge *br, struct net_bridge_port *p);
/* br_forward.c */
void br_deliver(const struct net_bridge_port *to, struct sk_buff *skb);
--
1.9.0
next prev parent reply other threads:[~2014-04-29 21:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-29 21:20 [RFC PATCH v2 net-next 0/7] Non-promisc bidge ports support Vlad Yasevich
2014-04-29 21:20 ` [RFC PATCH v2 net-next 1/7] bridge: Turn flag change macro into a function Vlad Yasevich
2014-04-29 21:20 ` [RFC PATCH v2 net-next 2/7] bridge: Keep track of ports capable of automatic discovery Vlad Yasevich
2014-04-30 10:18 ` Michael S. Tsirkin
2014-04-30 13:47 ` Vlad Yasevich
2014-04-29 21:20 ` Vlad Yasevich [this message]
2014-04-29 21:20 ` [RFC PATCH v2 net-next 4/7] bridge: Automatically manage port promiscuous mode Vlad Yasevich
2014-04-30 11:46 ` Michael S. Tsirkin
2014-04-30 14:17 ` Vlad Yasevich
2014-04-30 15:38 ` Michael S. Tsirkin
2014-04-29 21:20 ` [RFC PATCH v2 net-next 5/7] bridge: Add addresses from static fdbs to non-promisc ports Vlad Yasevich
2014-04-29 21:20 ` [RFC PATCH v2 net-next 6/7] bridge: Correctly manage promiscuity when user requested it Vlad Yasevich
2014-04-29 21:20 ` [RFC PATCH v2 net-next 7/7] bridge: Automatically manage promisc mode when vlan filtering is on Vlad Yasevich
2014-04-30 17:22 ` [RFC PATCH v2 net-next 0/7] Non-promisc bidge ports support Stephen Hemminger
2014-04-30 17:37 ` Michael S. Tsirkin
2014-04-30 18:50 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398806428-640-4-git-send-email-vyasevic@redhat.com \
--to=vyasevic@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=jhs@mojatatu.com \
--cc=john.r.fastabend@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).