* [PATCH net] bpf_dbg: fix wrong register usage
@ 2014-04-30 8:24 Daniel Borkmann
2014-04-30 20:16 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Borkmann @ 2014-04-30 8:24 UTC (permalink / raw)
To: davem; +Cc: netdev, Brendan Hickey
From: Brendan Hickey <bhickey@google.com>
The AND instruction is erroneously using the X register instead
of the K register.
Signed-off-by: Brendan Hickey <bhickey@google.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
---
Resending correctly for Brendan. (I'm back from vaction on 11th
of May, so I don't have much Internet access, I didn't want to
get this one lost in meantime though.)
tools/net/bpf_dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/net/bpf_dbg.c b/tools/net/bpf_dbg.c
index bb31813..9a287be 100644
--- a/tools/net/bpf_dbg.c
+++ b/tools/net/bpf_dbg.c
@@ -820,7 +820,7 @@ do_div:
r->A &= r->X;
break;
case BPF_ALU_AND | BPF_K:
- r->A &= r->X;
+ r->A &= K;
break;
case BPF_ALU_OR | BPF_X:
r->A |= r->X;
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] bpf_dbg: fix wrong register usage
2014-04-30 8:24 [PATCH net] bpf_dbg: fix wrong register usage Daniel Borkmann
@ 2014-04-30 20:16 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-04-30 20:16 UTC (permalink / raw)
To: dborkman; +Cc: netdev, bhickey
From: Daniel Borkmann <dborkman@redhat.com>
Date: Wed, 30 Apr 2014 10:24:38 +0200
> From: Brendan Hickey <bhickey@google.com>
>
> The AND instruction is erroneously using the X register instead
> of the K register.
>
> Signed-off-by: Brendan Hickey <bhickey@google.com>
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-30 20:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-30 8:24 [PATCH net] bpf_dbg: fix wrong register usage Daniel Borkmann
2014-04-30 20:16 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).