From: Harish Patil <harish.patil@qlogic.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>,
Shahed Shaikh <shahed.shaikh@qlogic.com>,
<Dept-HSGLinuxNICDev@qlogic.com>, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH net-next] qlcnic: Fix Kconfig dependency on HWMON
Date: Wed, 7 May 2014 02:06:15 -0400 [thread overview]
Message-ID: <1399442775-20610-1-git-send-email-harish.patil@qlogic.com> (raw)
Commit 1f0f467b670e "qlcnic: Add hwmon interface to export board
temperature" introduced a randconfig build error in the case
when the hwmon framework is built as a module and the qlcnic
driver itself is built-in:
drivers/built-in.o: In function `qlcnic_register_hwmon_dev':
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c:1301:
undefined reference to `hwmon_device_register_with_groups'
drivers/built-in.o: In function `qlcnic_unregister_hwmon_dev':
drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c:1309:
undefined reference to `hwmon_device_unregister'.
This changes the Kconfig logic to enforce that the qlcnic hwmon
support can only be enabled if it is possible to successfully
build it.
Signed-off-by: Harish Patil <harish.patil@qlogic.com>
Reported-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/net/ethernet/qlogic/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/qlogic/Kconfig b/drivers/net/ethernet/qlogic/Kconfig
index b818432..d49cba1 100644
--- a/drivers/net/ethernet/qlogic/Kconfig
+++ b/drivers/net/ethernet/qlogic/Kconfig
@@ -68,7 +68,7 @@ config QLCNIC_VXLAN
config QLCNIC_HWMON
bool "QLOGIC QLCNIC 82XX and 83XX family HWMON support"
- depends on QLCNIC && HWMON
+ depends on QLCNIC && HWMON && !(QLCNIC=y && HWMON=m)
default y
---help---
This configuration parameter can be used to read the
--
1.8.1.4
next reply other threads:[~2014-05-07 6:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 6:06 Harish Patil [this message]
2014-05-07 21:23 ` [PATCH net-next] qlcnic: Fix Kconfig dependency on HWMON David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399442775-20610-1-git-send-email-harish.patil@qlogic.com \
--to=harish.patil@qlogic.com \
--cc=Dept-HSGLinuxNICDev@qlogic.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shahed.shaikh@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).