From: Joe Perches <joe@perches.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: akpm@linux-foundation.org,
David Ertman <davidx.m.ertman@intel.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] checkpatch.pl: Fix checkpatch false positive due to ternary operator break
Date: Fri, 09 May 2014 21:47:16 -0700 [thread overview]
Message-ID: <1399697236.2912.43.camel@joe-AO725> (raw)
In-Reply-To: <1399696911-6550-1-git-send-email-jeffrey.t.kirsher@intel.com>
On Fri, 2014-05-09 at 21:41 -0700, Jeff Kirsher wrote:
> From: David Ertman <davidx.m.ertman@intel.com>
Hey David.
> Using the intuitive breaking of a ternary operator used in the
> initialization of a variable in its declaration:
>
> type var = FOO ?
> BAR :
> FEE;
[]
> type var = FOO
> ? BAR
> : FEE;
>
> Change checkpatch so that it is checking fot the correct breaking of ternary
> operators used in networking variable declaration/initialization.
There is no "correct" breaking for ternary operators.
Both should be acceptable.
prev parent reply other threads:[~2014-05-10 4:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-10 4:41 [PATCH] checkpatch.pl: Fix checkpatch false positive due to ternary operator break Jeff Kirsher
2014-05-10 4:47 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399697236.2912.43.camel@joe-AO725 \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=davidx.m.ertman@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).