From: Yang Yingliang <yangyingliang@huawei.com>
To: <stephen@networkplumber.org>
Cc: <netdev@vger.kernel.org>, <eric.dumazet@gmail.com>
Subject: [PATCH iproute2] fq: don't allow set options to zero
Date: Mon, 12 May 2014 12:18:39 +0800 [thread overview]
Message-ID: <1399868319-2184-1-git-send-email-yangyingliang@huawei.com> (raw)
Now options of fair queue can be zero but cannot be (~0U).
Zero is useless, so don't allow set the options to zero.
Also, maxrate cannot be reset to unlimited because it
cannot be (~0U).
Cc: Eric Dumazet <edumazet@google.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
tc/q_fq.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/tc/q_fq.c b/tc/q_fq.c
index c1f658e..c529842 100644
--- a/tc/q_fq.c
+++ b/tc/q_fq.c
@@ -71,13 +71,13 @@ static unsigned int ilog2(unsigned int val)
static int fq_parse_opt(struct qdisc_util *qu, int argc, char **argv,
struct nlmsghdr *n)
{
- unsigned int plimit = ~0U;
- unsigned int flow_plimit = ~0U;
- unsigned int quantum = ~0U;
- unsigned int initial_quantum = ~0U;
+ unsigned int plimit = 0;
+ unsigned int flow_plimit = 0;
+ unsigned int quantum = 0;
+ unsigned int initial_quantum = 0;
unsigned int buckets = 0;
- unsigned int maxrate = ~0U;
- unsigned int defrate = ~0U;
+ unsigned int maxrate = 0;
+ unsigned int defrate = 0;
int pacing = -1;
struct rtattr *tail;
@@ -147,24 +147,24 @@ static int fq_parse_opt(struct qdisc_util *qu, int argc, char **argv,
addattr_l(n, 1024, TCA_FQ_BUCKETS_LOG,
&log, sizeof(log));
}
- if (plimit != ~0U)
+ if (plimit)
addattr_l(n, 1024, TCA_FQ_PLIMIT,
&plimit, sizeof(plimit));
- if (flow_plimit != ~0U)
+ if (flow_plimit)
addattr_l(n, 1024, TCA_FQ_FLOW_PLIMIT,
&flow_plimit, sizeof(flow_plimit));
- if (quantum != ~0U)
+ if (quantum)
addattr_l(n, 1024, TCA_FQ_QUANTUM, &quantum, sizeof(quantum));
- if (initial_quantum != ~0U)
+ if (initial_quantum)
addattr_l(n, 1024, TCA_FQ_INITIAL_QUANTUM,
&initial_quantum, sizeof(initial_quantum));
if (pacing != -1)
addattr_l(n, 1024, TCA_FQ_RATE_ENABLE,
&pacing, sizeof(pacing));
- if (maxrate != ~0U)
+ if (maxrate)
addattr_l(n, 1024, TCA_FQ_FLOW_MAX_RATE,
&maxrate, sizeof(maxrate));
- if (defrate != ~0U)
+ if (defrate)
addattr_l(n, 1024, TCA_FQ_FLOW_DEFAULT_RATE,
&defrate, sizeof(defrate));
tail->rta_len = (void *) NLMSG_TAIL(n) - (void *) tail;
--
1.8.0
next reply other threads:[~2014-05-12 4:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 4:18 Yang Yingliang [this message]
2014-05-12 5:58 ` [PATCH iproute2] fq: don't allow set options to zero Eric Dumazet
2014-05-12 6:51 ` Yang Yingliang
2014-05-12 6:55 ` Yang Yingliang
2014-05-12 6:59 ` Yang Yingliang
2014-05-12 15:23 ` Eric Dumazet
2014-05-13 2:23 ` [PATCH iproute2 v2] fq: allow options of fair queue set to ~0U Yang Yingliang
2014-05-13 3:03 ` Eric Dumazet
2014-05-13 4:10 ` Yang Yingliang
2014-05-13 4:20 ` [PATCH iproute2 v3] " Yang Yingliang
2014-05-29 0:09 ` Stephen Hemminger
2014-05-29 2:43 ` Yang Yingliang
2014-05-29 4:04 ` [PATCH iproute2 v4] " Yang Yingliang
2014-06-09 19:43 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399868319-2184-1-git-send-email-yangyingliang@huawei.com \
--to=yangyingliang@huawei.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).