From: Eyal Birger <eyal.birger@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: David Miller <davem@davemloft.net>,
Shmulik Ladkani <shmulik.ladkani@gmail.com>,
Eric Dumazet <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v3 3/4] net: use skb->priority for overloading skb->dropcount and skb->reserved_tailroom instead of skb->mark
Date: Tue, 24 Feb 2015 16:41:16 +0200 [thread overview]
Message-ID: <13A594FB-4232-4AC0-BADE-778B5D452633@gmail.com> (raw)
In-Reply-To: <1424787949.5565.76.camel@edumazet-glaptop2.roam.corp.google.com>
> On 24 Feb 2015, at 16:25, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>
> On Tue, 2015-02-24 at 16:07 +0200, Eyal Birger wrote:
>
>>> rxpc is buggy right now anyway, as it reads skb->mark _and_ uses
>>> sock_recv_ts_and_drops(), so skb->mark value is pretty much void.
>>
>> Yes, but it does not seem to use sock_queue_rcv_skb() which sets skb->dropcount.
>
> Well, SO_RXQ_OVFL is broken for these sockets, as we'll report a
> dropcount if skb->mark was set.
>
>
Right. That feature seems broken.
Fixing it would mean either
avoiding the use of skb->mark in
rxrpc or aliasing dropcount with
something else.
I am also not sure what should be the
semantics of SO_RCVMARK on these
sockets.
next prev parent reply other threads:[~2015-02-24 14:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 17:52 [PATCH net-next v3 1/4] net: Rename sock_recv_ts_and_drops() to sock_cmsg_recv() Eyal Birger
2015-02-23 17:52 ` [PATCH net-next v3 2/4] ipv4,v6: avoid setting skb->priority when skb->reserved_tailroom is in use in igmpv3/mld Eyal Birger
2015-02-23 17:52 ` [PATCH net-next v3 3/4] net: use skb->priority for overloading skb->dropcount and skb->reserved_tailroom instead of skb->mark Eyal Birger
2015-02-23 18:56 ` Shmulik Ladkani
2015-02-23 19:10 ` Eric Dumazet
2015-02-23 19:25 ` Eyal Birger
2015-02-23 19:51 ` Eric Dumazet
2015-02-23 21:48 ` David Miller
2015-02-24 6:58 ` Eyal Birger
2015-02-24 10:10 ` Eyal Birger
2015-02-24 13:18 ` Eric Dumazet
2015-02-24 14:07 ` Eyal Birger
2015-02-24 14:25 ` Eric Dumazet
2015-02-24 14:41 ` Eyal Birger [this message]
2015-02-24 14:41 ` Eric Dumazet
2015-02-24 15:24 ` Eyal Birger
2015-02-25 20:49 ` Willem de Bruijn
2015-02-25 21:15 ` Eyal Birger
2015-02-25 14:10 ` Eyal Birger
2015-02-25 16:50 ` Eric Dumazet
2015-02-23 17:52 ` [PATCH net-next v3 4/4] net: Introducing socket mark receive socket option Eyal Birger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13A594FB-4232-4AC0-BADE-778B5D452633@gmail.com \
--to=eyal.birger@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shmulik.ladkani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).