From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.holtmann.org (mail.holtmann.org [81.169.141.235]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 820EF51815B; Tue, 29 Sep 2026 17:14:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=81.169.141.235 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790702078; cv=none; b=uQOF2U8RPdB5SJUFTxgYmkywecfFfI7XYjMypWFV9KpfIgWFJ58+62TfZrvif3lmCYsBaE35FNKKWZ5ZFCxrjxuBKsSOV2Z/u4L6O8PXRfPfyEL99srYIQvOnyVkK2EgomOaD//AGSWYx4Ioe5WUFR/ZD8e+g5er0x31deKBe8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790702078; c=relaxed/simple; bh=kmQ1hbQPD5iWUSj9w4INyopw+EVylQeht+K3g4IU9JM=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=qKllbXwfRAiwxvGIAnWGtdClGFyJxCdEAHEmGNCDnzm0lVK26xxM1HTuJvvgaQaGrq+KJ73jZqW+kdW6YxjtOUKQ1/tWA9bsCJB6uUOAr8rVodabYCFHsHq3nJJC8eg198AY4+GDTvnj0ULn9QDju/HReT2wZ86ubRhXrbBuoQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=holtmann.org; spf=pass smtp.mailfrom=holtmann.org; arc=none smtp.client-ip=81.169.141.235 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=holtmann.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=holtmann.org Received: from smtpclient.apple (p5b0a9ac0.dip0.t-ipconnect.de [91.10.154.192]) by mail.holtmann.org (Postfix) with ESMTPSA id 0F38CFF100; Tue, 29 Sep 2026 19:05:42 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.100.1.1.12\)) Subject: Re: [PATCH v3 2/4] net: qrtr: Assign unique node id for MHI endpoints From: Marcel Holtmann In-Reply-To: <7aed969d-0868-4c9c-967e-7766dbba427e@oss.qualcomm.com> Date: Tue, 29 Sep 2026 19:05:31 +0200 Cc: manivannan.sadhasivam@oss.qualcomm.com, Manivannan Sadhasivam , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jeff Johnson , linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, Bjorn Andersson , Chris Lew , Raj Kumar Bhagat , Juha-Matti Tilli , Jeff Hugo Content-Transfer-Encoding: quoted-printable Message-Id: <13BFC5B0-77E6-48F2-B857-37686EA1DB2C@holtmann.org> References: <20260922-qrtr-multi-ep-v3-0-c00831e88957@oss.qualcomm.com> <20260922-qrtr-multi-ep-v3-2-c00831e88957@oss.qualcomm.com> <7aed969d-0868-4c9c-967e-7766dbba427e@oss.qualcomm.com> To: Deepak Kumar Singh X-Mailer: Apple Mail (2.3901.100.1.1.12) Hi Deepak, >> Now that the QRTR driver allows using the unique node id for each = device, >> which is different from the node id received from the remote node, = compute >> a unique node id using a new API, qrtr_host_node_id(). >>=20 >> This API takes the 'index' parameter and adds it to = QRTR_NODE_HOST_BASE, >> whose value is outside of the node id range used by the remote nodes = (0 to >> 0xffff). >>=20 >> Finally, call the new API from MHI endpoint driver by passing the MHI >> controller index as the parameter. The MHI controller index is unique = for >> each controller, thereby for each MHI endpoint device. >>=20 >> Signed-off-by: Manivannan Sadhasivam = >> --- >> MAINTAINERS | 1 + >> include/net/qrtr.h | 21 +++++++++++++++++++++ >> net/qrtr/mhi.c | 4 +++- >> 3 files changed, 25 insertions(+), 1 deletion(-) >>=20 >> diff --git a/MAINTAINERS b/MAINTAINERS >> index df8ab9b82402..9c8bb086be28 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -22511,6 +22511,7 @@ QUALCOMM IPC ROUTER (QRTR) DRIVER >> M: Manivannan Sadhasivam >> L: linux-arm-msm@vger.kernel.org >> S: Maintained >> +F: include/net/qrtr.h >> F: include/trace/events/qrtr.h >> F: include/uapi/linux/qrtr.h >> F: net/qrtr/ >> diff --git a/include/net/qrtr.h b/include/net/qrtr.h >> new file mode 100644 >> index 000000000000..745d51b4a6ba >> --- /dev/null >> +++ b/include/net/qrtr.h >> @@ -0,0 +1,21 @@ >> +/* SPDX-License-Identifier: GPL-2.0 */ >> + >> +#ifndef _NET_QRTR_H >> +#define _NET_QRTR_H >> + >> +#include >> + >> +/* The offset is chosen carefully to not collide with the node ids = allocated by >> + * the remote nodes. All the remote nodes use node ids in range 0 to = 0xffff. >> + */ >> +#define QRTR_NODE_HOST_BASE 0x10000u >=20 > Can it be exposed with include/uapi/linux/qrtr.h also. There are user = space clients like modem manager > which need to calculate modified node id to distinguish same service = from multi modem over mhi. > This is same as wlan use case. did anybody actually looked at the proposal that Denis and I came up = with. It was exactly addressing this properly. It seems you guys came up with some hot fix and want to run with it. = After month and month of silence and not bothering to review the = proposal, you are trying to push your thing? If you don=E2=80=99t support userspace, your proposal is broken. Plain = and simple. Regards Marcel