Re: [RFC iproute2 v5 1/3] ss: add support for BPF socket-local storage

[Martin KaFai Lau <martin.lau@linux.dev>]

On 1/15/24 8:46 AM, Quentin Deslandes wrote:
> +static struct rtattr *bpf_map_opts_alloc_rta(void)
> +{
> +	struct rtattr *stgs_rta, *fd_rta;
> +	size_t total_size;
> +	unsigned int i;
> +	void *buf;
> +
> +	/* If bpf_map_opts.show_all == true, we will send an empty message to
> +	 * the kernel, which will return all the socket-local data attached to
> +	 * a socket, no matter their map ID. */
> +	if (bpf_map_opts.show_all) {
> +		total_size = RTA_LENGTH(0);

This addressed the issue I saw in v4. Thanks!

The set is already very useful in the current form. Thanks for working on it.

> +	} else {
> +		total_size = RTA_LENGTH(RTA_LENGTH(sizeof(int)) *
> +					bpf_map_opts.nr_maps);
> +	}