From: Matt Johnston <matt@codeconstruct.com.au>
To: Dan Carpenter <dan.carpenter@linaro.org>,
oe-kbuild@lists.linux.dev, Jeremy Kerr <jk@codeconstruct.com.au>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 5/7] net: mctp: Allow limiting binds to a peer address
Date: Tue, 15 Jul 2025 09:13:35 +0800 [thread overview]
Message-ID: <13bda0930870d96ca0c27da57c9b1bf144cc89c1.camel@codeconstruct.com.au> (raw)
In-Reply-To: <a51b1a51-8ff6-4607-b783-1944d324359d@suswa.mountain>
Hi,
On Mon, 2025-07-14 at 22:16 +0300, Dan Carpenter wrote:
> patch link: https://lore.kernel.org/r/20250703-mctp-bind-v1-5-bb7e97c24613%40codeconstruct.com.au
> patch subject: [PATCH net-next 5/7] net: mctp: Allow limiting binds to a peer address
...
> smatch warnings:
> net/mctp/af_mctp.c:122 mctp_bind() warn: inconsistent returns 'sk'.
...
> d58bad174be0c4b Matt Johnston 2025-07-03 98 if (msk->bind_peer_set) {
> d58bad174be0c4b Matt Johnston 2025-07-03 99 if (msk->bind_type != smctp->smctp_type) {
> d58bad174be0c4b Matt Johnston 2025-07-03 100 /* Prior connect() had a different type */
> d58bad174be0c4b Matt Johnston 2025-07-03 101 return -EINVAL;
>
> goto out_release?
This was fixed in the v4 series.
Cheers,
Matt
next prev parent reply other threads:[~2025-07-15 1:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 9:11 [PATCH net-next 0/7] net: mctp: Improved bind handling Matt Johnston
2025-07-03 9:11 ` [PATCH net-next 1/7] net: mctp: Prevent duplicate binds Matt Johnston
2025-07-03 9:11 ` [PATCH net-next 2/7] net: mctp: Treat MCTP_NET_ANY specially in bind() Matt Johnston
2025-07-03 9:11 ` [PATCH net-next 3/7] net: mctp: Add test for conflicting bind()s Matt Johnston
2025-07-04 11:55 ` kernel test robot
2025-07-03 9:11 ` [PATCH net-next 4/7] net: mctp: Use hashtable for binds Matt Johnston
2025-07-03 9:11 ` [PATCH net-next 5/7] net: mctp: Allow limiting binds to a peer address Matt Johnston
2025-07-14 19:16 ` Dan Carpenter
2025-07-15 1:13 ` Matt Johnston [this message]
2025-07-03 9:11 ` [PATCH net-next 6/7] net: mctp: Test conflicts of connect() with bind() Matt Johnston
2025-07-04 11:01 ` kernel test robot
2025-07-03 9:11 ` [PATCH net-next 7/7] net: mctp: Add bind lookup test Matt Johnston
2025-08-11 11:35 ` Alexandre Ghiti
2025-08-12 5:11 ` Matt Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13bda0930870d96ca0c27da57c9b1bf144cc89c1.camel@codeconstruct.com.au \
--to=matt@codeconstruct.com.au \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jk@codeconstruct.com.au \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).