netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>, netdev@vger.kernel.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Björn Töpel" <bjorn.topel@intel.com>,
	"Magnus Karlsson" <magnus.karlsson@intel.com>,
	"Jonathan Lemon" <jonathan.lemon@gmail.com>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Jesper Dangaard Brouer" <hawk@kernel.org>,
	"John Fastabend" <john.fastabend@gmail.com>,
	"Andrii Nakryiko" <andrii@kernel.org>,
	"Martin KaFai Lau" <kafai@fb.com>,
	"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
	"KP Singh" <kpsingh@kernel.org>,
	virtualization@lists.linux-foundation.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 1/3] net: add priv_flags for allow tx skb without linear
Date: Wed, 20 Jan 2021 11:01:24 +0800	[thread overview]
Message-ID: <13d2ceda-16d1-488c-d131-55cca813b224@redhat.com> (raw)
In-Reply-To: <30ae1c94b5c26919bd90bb251761c526edfbaf56.1611048724.git.xuanzhuo@linux.alibaba.com>


On 2021/1/19 下午5:45, Xuan Zhuo wrote:
> In some cases, we hope to construct skb directly based on the existing
> memory without copying data. In this case, the page will be placed
> directly in the skb, and the linear space of skb is empty. But
> unfortunately, many the network card does not support this operation.
> For example Mellanox Technologies MT27710 Family [ConnectX-4 Lx] will
> get the following error message:
>
>      mlx5_core 0000:3b:00.1 eth1: Error cqe on cqn 0x817, ci 0x8, qn 0x1dbb, opcode 0xd, syndrome 0x1, vendor syndrome 0x68
>      00000000: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>      00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>      00000020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>      00000030: 00 00 00 00 60 10 68 01 0a 00 1d bb 00 0f 9f d2
>      WQE DUMP: WQ size 1024 WQ cur size 0, WQE index 0xf, len: 64
>      00000000: 00 00 0f 0a 00 1d bb 03 00 00 00 08 00 00 00 00
>      00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>      00000020: 00 00 00 2b 00 08 00 00 00 00 00 05 9e e3 08 00
>      00000030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
>      mlx5_core 0000:3b:00.1 eth1: ERR CQE on SQ: 0x1dbb
>
> So a priv_flag is added here to indicate whether the network card
> supports this feature.


I don't see Mellanox engineers are copied. I wonder if we need their 
confirmation on whether it's a bug or hardware limitation.

Thanks


  reply	other threads:[~2021-01-20  3:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-19  9:45 [PATCH bpf-next v2 0/3] xsk: build skb by page Xuan Zhuo
2021-01-19  9:45 ` [PATCH bpf-next v2 1/3] net: add priv_flags for allow tx skb without linear Xuan Zhuo
2021-01-20  3:01   ` Jason Wang [this message]
2021-01-19  9:45 ` [PATCH bpf-next v2 2/3] virtio-net: support IFF_TX_SKB_NO_LINEAR Xuan Zhuo
2021-01-19 14:28   ` Alexander Lobakin
     [not found]     ` <cover.1611128806.git.xuanzhuo@linux.alibaba.com>
2021-01-20  7:49       ` [PATCH net-next " Xuan Zhuo
2021-01-20  7:57         ` Michael S. Tsirkin
2021-01-20  7:50       ` [PATCH net-next v2 3/3] xsk: build skb by page Xuan Zhuo
2021-01-20  8:10         ` Michael S. Tsirkin
2021-01-20  8:11           ` Michael S. Tsirkin
     [not found]           ` <cover.1611131344.git.xuanzhuo@linux.alibaba.com>
2021-01-20  8:30             ` Xuan Zhuo
2021-01-20 13:56               ` Alexander Lobakin
2021-01-21  7:41                 ` Magnus Karlsson
2021-01-21 10:54                   ` Yunsheng Lin
2021-01-19  9:45 ` [PATCH bpf-next " Xuan Zhuo
2021-01-19 14:43   ` Alexander Lobakin
2021-01-19  9:50 ` [PATCH bpf-next v2 0/3] " Michael S. Tsirkin
     [not found]   ` <1611053609.502882-1-xuanzhuo@linux.alibaba.com>
2021-01-19 11:02     ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13d2ceda-16d1-488c-d131-55cca813b224@redhat.com \
    --to=jasowang@redhat.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bjorn.topel@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=jonathan.lemon@gmail.com \
    --cc=kafai@fb.com \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=magnus.karlsson@intel.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=xuanzhuo@linux.alibaba.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).