From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH net] net: mvpp2: Extract the correct ethtype from the skb for tx csum offload Date: Thu, 4 Oct 2018 12:50:17 +0300 Message-ID: <13fb6bd4-db67-6c35-9e6d-09ed89e10a45@cogentembedded.com> References: <20181004080308.7687-1-maxime.chevallier@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Antoine Tenart , thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com To: Maxime Chevallier , davem@davemloft.net Return-path: In-Reply-To: <20181004080308.7687-1-maxime.chevallier@bootlin.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello! On 10/4/2018 11:03 AM, Maxime Chevallier wrote: > When offloading the L3 and L4 csum computation on TX, we need to extract > the l3_proto from the ethtype, independently of the presence of a vlan > tag. > > The actual driver uses skb->protocol as-is, resulting in packets with > the wrong L4 checksum being sent when there's a vlan tag in the packet > header and checksum offloading is enabled. > > This commit makes use of vlan_protocol_get() to get the correct ethtype > regardless the presence of a vlan tag. ^ of? > Fixes: 3f51850 ("ethernet: Add new driver for Marvell Armada 375 network unit") 12 hex digits needed here. > Signed-off-by: Maxime Chevallier [...] MBR, Sergei