From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C07451FB35 for ; Wed, 23 Aug 2023 21:40:52 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 601EA1AD for ; Wed, 23 Aug 2023 14:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692826831; x=1724362831; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=fZ8c/Y5YttnT2gv2blBChMcfoXiq6Nsl08kGNddaGnI=; b=OznxxfibjnPxXzXxo/pV09o1v8T6UylWVraJtO8x4YEAH4jqIrvYIhLl MGopsuBwgcC3uxSRR2O08GDCi9wRDeZ9+pHp7oF8tREQEVp62BYEtv17x XRjdEJR7yiQ5PrE/hAwevvh/H/7Lf7Aq7AVRVcf40lHqAeLB7dbLGM/qm MpwhXXla6wHsipl/QCcJqYoina/0V5SfK3FeJF5J+fJghvIDXF7qXrXPV SUzGSZl4sEwjgIlQoe3Zfqh+PAXOFNfz7leNt3ZpB3JnBn4gIVkhrp7LB M2TLBjsWy0W+xL4/0m9ZbZSXb+OhZuYoQGWSMO/YJEj1sK17Pbitno0R3 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10811"; a="373163484" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="373163484" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2023 14:39:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10811"; a="826886673" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="826886673" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 23 Aug 2023 14:39:29 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 23 Aug 2023 14:39:29 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 23 Aug 2023 14:39:28 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 23 Aug 2023 14:39:28 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 23 Aug 2023 14:39:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q//0iIfsmk8QnV+COuL0XktvCInu5YLNSMkUdmvmDB5DXpXLC3ezzRLXxSdKI2Rqqy7bXjN/QM7bEWbpo9lV8juVN0N7zf/IJMWdUOLQgEFxKhgPuJt9ILHIpUxpqSz7TWmT0sj5gIx35ByzO2DptNitJY7uDDY+3Fj4LRNK+h5FrUr1lrDdiCOhX0BbXx6Akg3/n7DFABfsoIlREYzMc1Hl8IQEebmjGOB6MTyvLlMO9aWD2cDowPtOxUgrghbpurEpic2cSvQJszAtqAg7Qh8qdIqbGyOKZ5ExYWwKPuWabz/Pn2G6xPqgxpuwHCH/uA/9BPfbfN8UfgifRB62WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p3/mviq5vY/Y2d7X3IUCakNRo+igbojag7Qd6G6hO/w=; b=YdXG1IUiiyGi/UMtQYNy5Q0JXv5a8aaPvguxHOy/yJdeF83NqrpeWkXlZh9u/56U2O5KnFSgSDYWUhc8uwn6bc4hZoZt6Yz7pWv0Li10utCfNHpzmt5T0AxJR0EvSezMzctY1Dax6AvM8wRrtfJJ5Jw7eReL8LcFCz9zGtCqRrsMks5t7mobJEmYwSMk8MYTWfVovnA6x0Cd6tHSoSKfTtXa/NheGIbsraJqPFgHU4sVtsmPQ8nWjEwPsjYO9bQKAcz8yuFSVc5po1p3AMDUjH10FZ5ldklh7n+78drXoxZT/fyA9aMrE0CNr8Fl7CRJHwIlsEmMLhwSxGT68xeuXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from BYAPR11MB3175.namprd11.prod.outlook.com (2603:10b6:a03:7c::23) by BL1PR11MB5287.namprd11.prod.outlook.com (2603:10b6:208:31b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.26; Wed, 23 Aug 2023 21:39:26 +0000 Received: from BYAPR11MB3175.namprd11.prod.outlook.com ([fe80::4536:8199:4bbf:131f]) by BYAPR11MB3175.namprd11.prod.outlook.com ([fe80::4536:8199:4bbf:131f%7]) with mapi id 15.20.6699.026; Wed, 23 Aug 2023 21:39:25 +0000 Message-ID: <13fe03dd-9454-fbbb-775a-083e0bf85bad@intel.com> Date: Wed, 23 Aug 2023 14:39:23 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.14.0 Subject: Re: [PATCH iwl-next v4 0/5] iavf: Add devlink and devlink rate support' To: Jiri Pirko , Jakub Kicinski CC: Wenjun Wu , , , , , References: <20230727021021.961119-1-wenjun1.wu@intel.com> <20230822034003.31628-1-wenjun1.wu@intel.com> <20230822081255.7a36fa4d@kernel.org> Content-Language: en-US From: "Zhang, Xuejun" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR07CA0094.namprd07.prod.outlook.com (2603:10b6:a03:12b::35) To BYAPR11MB3175.namprd11.prod.outlook.com (2603:10b6:a03:7c::23) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR11MB3175:EE_|BL1PR11MB5287:EE_ X-MS-Office365-Filtering-Correlation-Id: 416df6b1-1aba-4fce-f445-08dba4216c10 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mKL+lwP9D5zChK64MXVGpIcKt1W319pEzNLoXICYEnZbq9mBHmkWTR0VgoIjCVcLNwaI6qhd9rnalWAvqCm/hJJ56m6jfypqpqkMDywq88s9G56kr+MqifH02+dBVnlOb2g+EJQJsK7JM+Un55n0P2S5JyUSspTROXW1hqNXH4dneJtsE0VjTzHggyX3hgAGX47yFGADY0mjZe9o6n8RlBZqeEPw7wO6IUSEhkQNcz+oHmNySPXluAJawS5YooafOy6xuU6sW8HkUMVZH0pVXBd3Srb+i11+0z204TtRYZSx365Pvz7+HzTPtmDTpKehFYD6UNuZvil1Zfse7qc8ljGrtqM1wZNqppyfb0ePTDuBdar98U5hn1/FZ6TpjWsl7THWW0rWozNypnL5+t9eJrmBrvrAlVQ1XTlt7hlsgkom8+oiNp/2H/8/Mts5TuHLpZMH1ZPPIiKrpTyhsLtynILBuPDwrsnoC/9j2mI2d1hzCHrC2V/y4XWNMJjUxfoBvVtZ/OaF1CmSK+52p4AbKfuKOXRssQwlzDuhvTWK5mJBwEcEWWYoTRt9VHpST5mKytRVbVvIp8hUAM6Et7lfFV/PePAHCoXwlAmoVd/9JVYfx1u7Oaix+J32deDYOdv3mGuiGctJTv2Rf4rjx1hKsg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR11MB3175.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(346002)(39860400002)(396003)(136003)(376002)(451199024)(186009)(1800799009)(4744005)(2906002)(6506007)(66946007)(53546011)(6486002)(478600001)(107886003)(26005)(2616005)(5660300002)(8676002)(4326008)(8936002)(38100700002)(31686004)(110136005)(66476007)(316002)(66556008)(6512007)(41300700001)(82960400001)(31696002)(86362001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDhQT0hzR056RDBQNGFBUW9pbzR0UHVGQjRzYXU0aHJKK0RqZzZPc1oycm45?= =?utf-8?B?b1hyaGEySE9lckZGejlEdy84MVZuUUhoZkZnZ1BPYnJMTjhEZWFnREtnOFB1?= =?utf-8?B?c0NLZDBNaWk0ZytHYmRyS0FtaE52OSthUjdIbnU5N0FSR0gzSURkcEdRMHo4?= =?utf-8?B?b1QySVR0SVRONUcwOXVzem1ZSjFiRkVLNUtVaVR4R2ZoY3RSN2hQNDYzb0ho?= =?utf-8?B?NVAycFkySTNVQXh6QXVSTklkSFlvTk5kMmErVGJOTVUwamZSdUNPOCs1by9j?= =?utf-8?B?UFFmdnFMYklwUVBiM2dLeTJ4b2FTY2p4OXV2YW9ZeUc5TlU5WkM4SHNZSy9W?= =?utf-8?B?bHErdUN1Sk1mT2pvUUx1WmdYNjRPdk5BZ2F6N2RnQklxQUVETmRXcFpwOUYw?= =?utf-8?B?dHdwbERFdVpsRVMydVhlSlFuQ2lreWJTVUNiVVl1elpid3I3dmZHa1Zsak52?= =?utf-8?B?akh6M1pTMnFickdnS2tmRkxvRVVhOUFoc1UxZ1VBNk12eUdFV3FZZXZ4SVJV?= =?utf-8?B?VE1nQXlidE9ocUZlaFlRNlNEbFhZWCtTNzFtczNHaitkejdFRS9nSXlUYmNu?= =?utf-8?B?VjZ5S09jMmpadVpyelExaENqWkFOeFVEaTllRHUvKzYwL1UzajAzc2V5c1Zu?= =?utf-8?B?b3ZQSEFHNGR2WjFHcVVualRtL3lpZEk2NmdBVFkzbjFVUTV0TGtOTmd1ZTlW?= =?utf-8?B?VTg0bTZrWm11MjRjN2pSZHdPQ0dJZDMwRERHUVFjV2trZkYzMUtydUpuWXBj?= =?utf-8?B?dWRnNXR5SXZFd2w0cWp1Rkd1OVRWaFhnWFJ2eW4rT1dWQU5CL0RIYmgzMVRF?= =?utf-8?B?dDhJNmlaeTdScDJSYWFJaHFlWU1zQTJWK3FVTmc2RThCQ2xQaFZaV1l0QSt6?= =?utf-8?B?MFFRQk9HTzFmenRjWThoNWY0T29jbVc1ejlsWFJPaGk5ZGluVVJkZzZDdkxN?= =?utf-8?B?TUVIa3pNTCt6N2hvblA5dVdFR1ZuVDliSUpwWkNoVmc0UTRDT0kxbDl0dVpD?= =?utf-8?B?SkUzcER3a2JDYkxJQm9YNlNNdUd3aGtNUDdydEp3dFg3WlM5UEptbjlLNTU3?= =?utf-8?B?RnNmV3F6Q3Bjd1gxRk5rZ1AvRzBoWVltd3kvaC9kaXZ6WXdHaTFGZEpZK1E4?= =?utf-8?B?bGhrS1N3OEN2ekN0STUrZStoZitoREdnaXJsSXg3ek1BYnY1U3JqK2NYaXhW?= =?utf-8?B?amVYYWdOVDlzOGZIcjBJTUM0ZjBHOERaeDgxaEpwMzRlMWdmSFdwNFFQL0pu?= =?utf-8?B?Rjc5Q2hwWnZsM2xrRy9PcWg3RkQ1bmZxMWtNdlZjL3pEVk9GT0VJRGFUeVRv?= =?utf-8?B?K2d3NXhlMERoc2J5Ulh0MmFMbWp6WGlrQTdvNm1MUGZ6Znpja0VvY1p6aElt?= =?utf-8?B?czFXNHZjZ1l6cHhDdVY0Vlh3K1NOMEs5VnB6RFVBVGtTdjJ6Nm9TZFAxYUdB?= =?utf-8?B?SVNZejFNTWRXV0Jvck4yM0RuZWtxRHM4cFJXWGN0VEx5SmhxMnFtS3gvSmhr?= =?utf-8?B?UFR6eWxNeitoRm0xVDdPUTdxbDhValBXYk9YaVlQano3bjNDWWdoVWpvMlhK?= =?utf-8?B?R3Yyd0FNOVhEejlBU2c2U1F5YTJjbTFmWGhXU0RHRmlKbG15L2ZKa3VzTGVT?= =?utf-8?B?b1RwMjRtZW5MN2Z6L24wNDQ1ek52Tit2ZytKdVI5dUZZNGlacTY5SW5UNkVB?= =?utf-8?B?M3VlMm5HNVdRZHMrbjZGZ2s2NEhiSWJKS3VnRTgrYTlEWjFCWlliRnVRSnhh?= =?utf-8?B?L1JmRDg1RURPeGlvbDJqVXRXb1E4aStNMWJ3VnZaUHMxY2RkR1VoWFNMTG5l?= =?utf-8?B?STRpbEloWnYrY0hIeDdHelBsTUNjNXpsSm9CVUhZNmlWT0xONGxBMUNQZHlw?= =?utf-8?B?eFVzazhEUVZOWmRhdWNnemJGOE5MczJDV3NXSGhWY2kvK1YyMjNOUW5kcXEv?= =?utf-8?B?b1Z6Y2hPdVA2Z2R6VWx6VnhPd0NYZXBDZ3FrZ1VJN2FWVjNPUmpKc3F1aURZ?= =?utf-8?B?MzdVSWFJTGtYVnAxK3NJRFFOakxscVpSbDFCNE5zRVpDOWpWaGt3OEZPU1Bj?= =?utf-8?B?WFRBaXVCT29HYXZPamd4TFNNWVNFdWxQdXBpelI4L1NXdW53RFg3QlM3Umlk?= =?utf-8?Q?bSIwZDj/DRKQQZj+2rsjISMTd?= X-MS-Exchange-CrossTenant-Network-Message-Id: 416df6b1-1aba-4fce-f445-08dba4216c10 X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3175.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2023 21:39:25.8387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aRGhorUg7+ubE4dZmgMDVDxKXFgMx4+sLYm1X+boNOBtf3+oK9KhVdM1Za1evQTkcg3cQKW+FlDf5JuO8yFGWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5287 X-OriginatorOrg: intel.com X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 8/22/2023 8:34 AM, Jiri Pirko wrote: > Tue, Aug 22, 2023 at 05:12:55PM CEST, kuba@kernel.org wrote: >> On Tue, 22 Aug 2023 08:12:28 +0200 Jiri Pirko wrote: >>> NACK! Port function is there to configure the VF/SF from the eswitch >>> side. Yet you use it for the configureation of the actual VF, which is >>> clear misuse. Please don't >> Stating where they are supposed to configure the rate would be helpful. > TC? Our implementation is an extension to this commit 42c2eb6b1f43 ice: Implement devlink-rate API). We are setting the Tx max & share rates of individual queues in a VF using the devlink rate API. Here we are using DEVLINK_PORT_FLAVOUR_VIRTUAL as the attribute for the port to distinguish it from being eswitch. [resend in plain text only]