netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Jacob Keller <jacob.e.keller@intel.com>,
	netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 09/11] ixgbe: add /* fallthrough */ comment to case statements
Date: Wed, 14 May 2014 01:54:21 -0700	[thread overview]
Message-ID: <1400057663-4578-10-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1400057663-4578-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Jacob Keller <jacob.e.keller@intel.com>

This semicomplex switch-case has various fallthrough portions, that were
not indicated by a /* fallthrough */ comment.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
index 0b9bfee..23e4e6a 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
@@ -2408,9 +2408,11 @@ static int ixgbe_get_rss_hash_opts(struct ixgbe_adapter *adapter,
 	switch (cmd->flow_type) {
 	case TCP_V4_FLOW:
 		cmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;
+		/* fallthrough */
 	case UDP_V4_FLOW:
 		if (adapter->flags2 & IXGBE_FLAG2_RSS_FIELD_IPV4_UDP)
 			cmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;
+		/* fallthrough */
 	case SCTP_V4_FLOW:
 	case AH_ESP_V4_FLOW:
 	case AH_V4_FLOW:
@@ -2420,9 +2422,11 @@ static int ixgbe_get_rss_hash_opts(struct ixgbe_adapter *adapter,
 		break;
 	case TCP_V6_FLOW:
 		cmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;
+		/* fallthrough */
 	case UDP_V6_FLOW:
 		if (adapter->flags2 & IXGBE_FLAG2_RSS_FIELD_IPV6_UDP)
 			cmd->data |= RXH_L4_B_0_1 | RXH_L4_B_2_3;
+		/* fallthrough */
 	case SCTP_V6_FLOW:
 	case AH_ESP_V6_FLOW:
 	case AH_V6_FLOW:
-- 
1.9.0

  parent reply	other threads:[~2014-05-14  8:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14  8:54 [net-next 00/11][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-05-14  8:54 ` [net-next 01/11] ixgbe: fix detection of SFP+ capable interfaces Jeff Kirsher
2014-05-14 12:26   ` Sergei Shtylyov
2014-05-14 16:59     ` Tantilov, Emil S
2014-05-14 18:16       ` Sergei Shtylyov
2014-05-14 18:22         ` Tantilov, Emil S
2014-05-14 19:00           ` David Miller
2014-05-14  8:54 ` [net-next 02/11] ixgbe: clean up checkpatch warnings about CODE_INDENT and LEADING_SPACE Jeff Kirsher
2014-05-14 16:25   ` Joe Perches
2014-05-14 20:48     ` Keller, Jacob E
2014-05-14  8:54 ` [net-next 03/11] ixgbe: fix function-like macro, remove semicolon Jeff Kirsher
2014-05-14  8:54 ` [net-next 04/11] ixgbe: fix checkpatch style of blank line after declaration Jeff Kirsher
2014-05-14  8:54 ` [net-next 05/11] ixgbe: fix several concatenated strings to single line Jeff Kirsher
2014-05-14  8:54 ` [net-next 06/11] ixgbe: add braces around else block Jeff Kirsher
2014-05-14  8:54 ` [net-next 07/11] ixgbe: don't check NULL for debugfs_remove_recursive Jeff Kirsher
2014-05-14  8:54 ` [net-next 08/11] ixgbe: add space between operands to & Jeff Kirsher
2014-05-14  8:54 ` Jeff Kirsher [this message]
2014-05-14  8:54 ` [net-next 10/11] igb/ixgbe: remove return statements for void functions Jeff Kirsher
2014-05-14  8:54 ` [net-next 11/11] i40e,igb,ixgbe: remove usless return statements Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400057663-4578-10-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=gospo@redhat.com \
    --cc=jacob.e.keller@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).