From: Vlad Yasevich <vyasevic@redhat.com>
To: netdev@vger.kernel.org
Cc: Vlad Yasevich <vyasevic@redhat.com>,
mst@redhat.com, bridge@lists.linux-foundation.org,
jhs@mojatatu.com, john.r.fastabend@intel.com,
shemminger@vyatta.com
Subject: [PATCH net-next 1/8] bridge: Turn flag change macro into a function.
Date: Wed, 14 May 2014 11:09:21 -0400 [thread overview]
Message-ID: <1400080168-16625-2-git-send-email-vyasevic@redhat.com> (raw)
In-Reply-To: <1400080168-16625-1-git-send-email-vyasevic@redhat.com>
Turn the flag change macro into a function to allow
easier updates and to reduce space.
Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
---
net/bridge/br_sysfs_if.c | 27 +++++++++++++++++----------
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c
index dd595bd..112a25e 100644
--- a/net/bridge/br_sysfs_if.c
+++ b/net/bridge/br_sysfs_if.c
@@ -41,20 +41,27 @@ static ssize_t show_##_name(struct net_bridge_port *p, char *buf) \
} \
static int store_##_name(struct net_bridge_port *p, unsigned long v) \
{ \
- unsigned long flags = p->flags; \
- if (v) \
- flags |= _mask; \
- else \
- flags &= ~_mask; \
- if (flags != p->flags) { \
- p->flags = flags; \
- br_ifinfo_notify(RTM_NEWLINK, p); \
- } \
- return 0; \
+ return store_flag(p, v, _mask); \
} \
static BRPORT_ATTR(_name, S_IRUGO | S_IWUSR, \
show_##_name, store_##_name)
+static int store_flag(struct net_bridge_port *p, unsigned long v,
+ unsigned long mask)
+{
+ unsigned long flags = p->flags;
+
+ if (v)
+ flags |= mask;
+ else
+ flags &= ~mask;
+
+ if (flags != p->flags) {
+ p->flags = flags;
+ br_ifinfo_notify(RTM_NEWLINK, p);
+ }
+ return 0;
+}
static ssize_t show_path_cost(struct net_bridge_port *p, char *buf)
{
--
1.9.0
next prev parent reply other threads:[~2014-05-14 15:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 15:09 [PATCH net-next 0/8] Non-promisc bidge ports support Vlad Yasevich
2014-05-14 15:09 ` Vlad Yasevich [this message]
2014-05-14 15:09 ` [PATCH net-next 2/8] bridge: Keep track of ports capable of automatic discovery Vlad Yasevich
2014-05-14 15:40 ` Stephen Hemminger
2014-05-14 15:42 ` Stephen Hemminger
2014-05-15 16:04 ` Vlad Yasevich
2014-05-14 15:09 ` [PATCH net-next 3/8] bridge: Add functionality to sync static fdb entries to hw Vlad Yasevich
2014-05-14 20:47 ` Sergei Shtylyov
2014-05-14 15:09 ` [PATCH net-next 4/8] bridge: Introduce BR_PROMISC flag Vlad Yasevich
2014-05-14 15:09 ` [PATCH net-next 5/8] bridge: Add addresses from static fdbs to non-promisc ports Vlad Yasevich
2014-05-14 20:44 ` Sergei Shtylyov
2014-05-14 15:09 ` [PATCH net-next 6/8] bridge: Automatically manage port promiscuous mode Vlad Yasevich
2014-05-14 15:09 ` [PATCH net-next 7/8] bridge: Correctly manage promiscuity when user requested it Vlad Yasevich
2014-05-14 15:09 ` [PATCH net-next 8/8] bridge: Automatically manage promisc mode when vlan filtering is on Vlad Yasevich
2014-05-14 20:41 ` Sergei Shtylyov
2014-05-14 15:21 ` [PATCH net-next 0/8] Non-promisc bidge ports support Michael S. Tsirkin
2014-05-14 19:29 ` David Miller
2014-05-15 16:09 ` Vlad Yasevich
2014-05-15 12:55 ` Toshiaki Makita
2014-05-15 13:02 ` Toshiaki Makita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400080168-16625-2-git-send-email-vyasevic@redhat.com \
--to=vyasevic@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=jhs@mojatatu.com \
--cc=john.r.fastabend@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).