From: Joe Perches <joe@perches.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next 02/11] ixgbe: clean up checkpatch warnings about CODE_INDENT and LEADING_SPACE
Date: Wed, 14 May 2014 09:25:57 -0700 [thread overview]
Message-ID: <1400084757.19788.12.camel@joe-AO725> (raw)
In-Reply-To: <1400057663-4578-3-git-send-email-jeffrey.t.kirsher@intel.com>
On Wed, 2014-05-14 at 01:54 -0700, Jeff Kirsher wrote:
trivial note:
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h
[]
> @@ -362,7 +362,7 @@ struct ixgbe_ring_container {
> for (pos = (head).ring; pos != NULL; pos = pos->next)
>
> #define MAX_RX_PACKET_BUFFERS ((adapter->flags & IXGBE_FLAG_DCB_ENABLED) \
> - ? 8 : 1)
> + ? 8 : 1)
My preference would be to use a form that keeps the
actual statement on a single line like:
#define MAX_RX_PACKET_BUFFERS \
(adapter->flags & IXGBE_FLAG_DCB_ENABLED ? 8 : 1)
or if you really like parentheses
#define MAX_RX_PACKET_BUFFERS \
((adapter->flags & IXGBE_FLAG_DCB_ENABLED) ? 8 : 1)
next prev parent reply other threads:[~2014-05-14 16:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-14 8:54 [net-next 00/11][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2014-05-14 8:54 ` [net-next 01/11] ixgbe: fix detection of SFP+ capable interfaces Jeff Kirsher
2014-05-14 12:26 ` Sergei Shtylyov
2014-05-14 16:59 ` Tantilov, Emil S
2014-05-14 18:16 ` Sergei Shtylyov
2014-05-14 18:22 ` Tantilov, Emil S
2014-05-14 19:00 ` David Miller
2014-05-14 8:54 ` [net-next 02/11] ixgbe: clean up checkpatch warnings about CODE_INDENT and LEADING_SPACE Jeff Kirsher
2014-05-14 16:25 ` Joe Perches [this message]
2014-05-14 20:48 ` Keller, Jacob E
2014-05-14 8:54 ` [net-next 03/11] ixgbe: fix function-like macro, remove semicolon Jeff Kirsher
2014-05-14 8:54 ` [net-next 04/11] ixgbe: fix checkpatch style of blank line after declaration Jeff Kirsher
2014-05-14 8:54 ` [net-next 05/11] ixgbe: fix several concatenated strings to single line Jeff Kirsher
2014-05-14 8:54 ` [net-next 06/11] ixgbe: add braces around else block Jeff Kirsher
2014-05-14 8:54 ` [net-next 07/11] ixgbe: don't check NULL for debugfs_remove_recursive Jeff Kirsher
2014-05-14 8:54 ` [net-next 08/11] ixgbe: add space between operands to & Jeff Kirsher
2014-05-14 8:54 ` [net-next 09/11] ixgbe: add /* fallthrough */ comment to case statements Jeff Kirsher
2014-05-14 8:54 ` [net-next 10/11] igb/ixgbe: remove return statements for void functions Jeff Kirsher
2014-05-14 8:54 ` [net-next 11/11] i40e,igb,ixgbe: remove usless return statements Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400084757.19788.12.camel@joe-AO725 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox