netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vince Bridgers <vbridgers2013@gmail.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: vbridgers2013@gmail.com
Subject: [PATCH net v2 0/2] Altera TSE: Fix Sparse errors and misc issues
Date: Wed, 14 May 2014 14:38:35 -0500	[thread overview]
Message-ID: <1400096317-4969-1-git-send-email-vbridgers2013@gmail.com> (raw)

This is version 2 of a patch series to correct sparse errors, cppcheck
warnings, and workaound a multicast filtering issue in the Altera TSE
Ethernet driver. Multicast filtering is not working as expected, so if
present in the hardware will not be used and promiscuous mode enabled
instead. This workaround will be replaced with a working solution when
completely debugged, integrated and tested. 

Version 2 is different from the first submission by breaking out the 
workaround as a seperate patch and addressing a few structure instance
declarations by making them const per review comments. 

If you find this patch acceptable, please consider this for inclusion into
the Altera TSE driver source code. 

Thank you

Vince


Vince Bridgers (2):
  Altera TSE: Fix sparse errors and warnings
  Altera TSE: Disable Multicast filtering to workaround problem

 drivers/net/ethernet/altera/Makefile             |    1 +
 drivers/net/ethernet/altera/altera_msgdma.c      |  110 ++++++-------
 drivers/net/ethernet/altera/altera_msgdmahw.h    |   13 +-
 drivers/net/ethernet/altera/altera_sgdma.c       |  181 +++++++++++-----------
 drivers/net/ethernet/altera/altera_sgdmahw.h     |   26 ++--
 drivers/net/ethernet/altera/altera_tse.h         |   47 ++++++
 drivers/net/ethernet/altera/altera_tse_ethtool.c |  108 ++++++++-----
 drivers/net/ethernet/altera/altera_tse_main.c    |  133 +++++++++-------
 drivers/net/ethernet/altera/altera_utils.c       |   20 +--
 drivers/net/ethernet/altera/altera_utils.h       |    8 +-
 10 files changed, 372 insertions(+), 275 deletions(-)

-- 
1.7.9.5

             reply	other threads:[~2014-05-14 19:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14 19:38 Vince Bridgers [this message]
2014-05-14 19:38 ` [PATCH net v2 1/2] Altera TSE: Fix sparse errors and warnings Vince Bridgers
2014-05-14 19:38 ` [PATCH net v2 2/2] Altera TSE: Disable Multicast filtering to workaround problem Vince Bridgers
2014-05-15 20:47 ` [PATCH net v2 0/2] Altera TSE: Fix Sparse errors and misc issues David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400096317-4969-1-git-send-email-vbridgers2013@gmail.com \
    --to=vbridgers2013@gmail.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).