From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: [PATCH net V2] xen-netback: don't move event pointer in TX credit timeout callback Date: Thu, 15 May 2014 12:59:18 +0100 Message-ID: <1400155158-13527-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , Wei Liu , Paul Durrant To: , Return-path: Received: from smtp.citrix.com ([66.165.176.89]:58820 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354AbaEOL7T (ORCPT ); Thu, 15 May 2014 07:59:19 -0400 Sender: netdev-owner@vger.kernel.org List-ID: ... otherwise the frontend will try to send TX event all the time, even if no progress can be made. The pointer should only be advanced by the routine that actually processes the ring (that is, xenvif_poll). Reported-by: Jacek Konieczny Signed-off-by: Wei Liu Acked-by: Ian Campbell Cc: Paul Durrant --- drivers/net/xen-netback/netback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c index 7666540..8e2cbeb 100644 --- a/drivers/net/xen-netback/netback.c +++ b/drivers/net/xen-netback/netback.c @@ -658,7 +658,7 @@ void xenvif_check_rx_xenvif(struct xenvif *vif) { int more_to_do; - RING_FINAL_CHECK_FOR_REQUESTS(&vif->tx, more_to_do); + more_to_do = RING_HAS_UNCONSUMED_REQUESTS(&vif->tx); if (more_to_do) napi_schedule(&vif->napi); -- 1.7.10.4