netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jon Maxwell <jmaxwell37@gmail.com>
To: stephen@networkplumber.org
Cc: davem@davemloft.net, makita.toshiaki@lab.ntt.co.jp,
	vyasevic@redhat.com, bridge@lists.linux-foundation.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	jpirko@redhat.com, jmaxwell@redhat.com,
	Jon Maxwell <jmaxwell37@gmail.com>
Subject: [PATCH net] bridge: notify user space of fdb port change
Date: Fri, 16 May 2014 17:28:44 +1000	[thread overview]
Message-ID: <1400225324-17748-1-git-send-email-jmaxwell@redhat.com> (raw)

From: Jon Maxwell <jmaxwell37@gmail.com>

There has been a number incidents recently where customers running KVM have 
reported that VM hosts on different Hypervisors are unreachable. Based on 
pcap traces we found that the bridge was broadcasting the ARP request out 
onto the network. However some NICs have an inbuilt switch which on occasions 
were broadcasting the VMs ARP request back through the physical NIC on the 
Hypervisor. This resulted in the bridge changing ports and incorrectly learning
that the VMs mac address was external. As a result the ARP reply was directed 
back onto the external network and VM never updated it's ARP cache. This patch 
will notify the bridge command to identify such port toggling.

Signed-off-by: Jon Maxwell <jmaxwell37@gmail.com>
---
 net/bridge/br_fdb.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
index 9203d5a..c2642f5 100644
--- a/net/bridge/br_fdb.c
+++ b/net/bridge/br_fdb.c
@@ -509,6 +509,8 @@ void br_fdb_update(struct net_bridge *br, struct net_bridge_port *source,
 			/* fastpath: update of existing entry */
 			fdb->dst = source;
 			fdb->updated = jiffies;
+			if (unlikely(source->port_no != fdb->dst->port_no))
+				fdb_notify(br, fdb, RTM_NEWNEIGH);
 			if (unlikely(added_by_user))
 				fdb->added_by_user = 1;
 		}
-- 
1.8.3.1

             reply	other threads:[~2014-05-16  7:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-16  7:28 Jon Maxwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-05-16  8:08 [PATCH net] bridge: notify user space of fdb port change Jon Maxwell
2014-05-16  8:12 ` Jon Maxwell
2014-05-16  8:54   ` Jon Maxwell
2014-05-13  7:55 Jon Maxwell
2014-05-13 15:16 ` Jiri Pirko
2014-05-13 15:28   ` Stephen Hemminger
2014-05-14  0:34 ` Toshiaki Makita
2014-05-14 21:07   ` Jon Maxwell
2014-05-23  4:59     ` Jon Maxwell
2014-05-23  8:39       ` Toshiaki Makita
2014-05-24  1:33         ` Jon Maxwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400225324-17748-1-git-send-email-jmaxwell@redhat.com \
    --to=jmaxwell37@gmail.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jmaxwell@redhat.com \
    --cc=jpirko@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=makita.toshiaki@lab.ntt.co.jp \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=vyasevic@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).