From: Vlad Yasevich <vyasevic@redhat.com>
To: netdev@vger.kernel.org
Cc: bridge@lists.linux-foundation.org, shemminger@vyatta.com,
mst@redhat.com, john.r.fastabend@intel.com,
Vlad Yasevich <vyasevic@redhat.com>
Subject: [PATCH v3 net-next 4/6] bridge: Introduce BR_PROMISC flag
Date: Fri, 16 May 2014 09:59:18 -0400 [thread overview]
Message-ID: <1400248760-20672-5-git-send-email-vyasevic@redhat.com> (raw)
In-Reply-To: <1400248760-20672-1-git-send-email-vyasevic@redhat.com>
Introduce a BR_PROMISC per-port flag that will help us track if the
current port is supposed to be in promiscuous mode or not. For now,
always start in promiscuous mode.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
---
net/bridge/br_if.c | 2 +-
net/bridge/br_private.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c
index f7ef5f2..3fefff9 100644
--- a/net/bridge/br_if.c
+++ b/net/bridge/br_if.c
@@ -238,7 +238,7 @@ static struct net_bridge_port *new_nbp(struct net_bridge *br,
p->path_cost = port_cost(dev);
p->priority = 0x8000 >> BR_PORT_BITS;
p->port_no = index;
- p->flags = BR_LEARNING | BR_FLOOD;
+ p->flags = BR_LEARNING | BR_FLOOD | BR_PROMISC;
br_init_port(p);
p->state = BR_STATE_DISABLED;
br_stp_port_timer_init(p);
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index c0a804b..00922a4 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -175,6 +175,7 @@ struct net_bridge_port
#define BR_LEARNING 0x00000020
#define BR_FLOOD 0x00000040
#define BR_AUTO_MASK (BR_FLOOD | BR_LEARNING)
+#define BR_PROMISC 0x00000080
#ifdef CONFIG_BRIDGE_IGMP_SNOOPING
struct bridge_mcast_query ip4_query;
@@ -200,6 +201,7 @@ struct net_bridge_port
};
#define br_auto_port(p) ((p)->flags & BR_AUTO_MASK)
+#define br_promisc_port(p) ((p)->flags & BR_PROMISC)
#define br_port_exists(dev) (dev->priv_flags & IFF_BRIDGE_PORT)
--
1.9.0
next prev parent reply other threads:[~2014-05-16 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 13:59 [PATCH v3 net-next 0/6] Non-promisc bidge ports support Vlad Yasevich
2014-05-16 13:59 ` [PATCH v3 net-next 1/6] bridge: Turn flag change macro into a function Vlad Yasevich
2014-05-16 13:59 ` [PATCH v3 net-next 2/6] bridge: Keep track of ports capable of automatic discovery Vlad Yasevich
2014-05-16 13:59 ` [PATCH v3 net-next 3/6] bridge: Add functionality to sync static fdb entries to hw Vlad Yasevich
2014-05-16 13:59 ` Vlad Yasevich [this message]
2014-05-16 13:59 ` [PATCH v3 net-next 5/6] bridge: Add addresses from static fdbs to non-promisc ports Vlad Yasevich
2014-05-16 13:59 ` [PATCH v3 net-next 6/6] bridge: Automatically manage port promiscuous mode Vlad Yasevich
2014-05-16 21:07 ` [PATCH v3 net-next 0/6] Non-promisc bidge ports support David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400248760-20672-5-git-send-email-vyasevic@redhat.com \
--to=vyasevic@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=john.r.fastabend@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).