From: Vlad Yasevich <vyasevic@redhat.com>
To: netdev@vger.kernel.org
Cc: dingtianhong@huawei.com, kaber@trash.net, vfalico@gmail.com,
jiri@resnulli.us, Vlad Yasevich <vyasevic@redhat.com>
Subject: [PATCH v3 0/4] Fix lockdep issues with stacked devices
Date: Fri, 16 May 2014 17:04:52 -0400 [thread overview]
Message-ID: <1400274296-14765-1-git-send-email-vyasevic@redhat.com> (raw)
Recent commit dc8eaaa006350d24030502a4521542e74b5cb39f
vlan: Fix lockdep warning when vlan dev handle notification
attempted to solve lockdep issues with vlans where multiple
vlans were stacked. However, the code does not work correctly
when the vlan stack is interspersed with other devices in between
the vlans. Additionally, similar lockdep issues show up with other
devices.
This series provides a generic way to solve these issue for any
devices that can be stacked. It also addresses the concern for
vlan and macvlan devices. I am not sure whether it makes sense
to do so for other types like team, vxlan, and bond.
Thanks
-vlad
Since v2:
- Remove rcu variants from patch1, since that function is called
only under rtnl.
- Fix whitespace problems reported by checkpatch
Since v1:
- Fixed up a goofed-up rebase.
* is_vlan_dev() should be bool and that change belongs in patch3.
* patch4 should not have any vlan changes in it.
Vlad Yasevich (4):
net: Find the nesting level of a given device by type.
net: Allow for more then a single subclass for netif_addr_lock
vlan: Fix lockdep warning with stacked vlan devices.
macvlan: Fix lockdep warnings with stacked macvlan devices
drivers/net/macvlan.c | 12 +++++++++--
include/linux/if_macvlan.h | 1 +
include/linux/if_vlan.h | 3 ++-
include/linux/netdevice.h | 18 +++++++++++++++-
net/8021q/vlan.c | 1 +
net/8021q/vlan_dev.c | 52 ++++++++--------------------------------------
net/core/dev.c | 49 ++++++++++++++++++++++++++++++++++++++++++-
7 files changed, 88 insertions(+), 48 deletions(-)
--
1.9.0
next reply other threads:[~2014-05-16 21:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 21:04 Vlad Yasevich [this message]
2014-05-16 21:04 ` [PATCH v3 1/4] net: Find the nesting level of a given device by type Vlad Yasevich
2014-05-17 2:16 ` David Miller
2014-05-16 21:04 ` [PATCH v3 2/4] net: Allow for more then a single subclass for netif_addr_lock Vlad Yasevich
2014-06-04 21:42 ` Keller, Jacob E
2014-06-04 21:53 ` David Miller
2014-06-04 22:50 ` Keller, Jacob E
2014-06-04 23:17 ` Vlad Yasevich
2014-05-16 21:04 ` [PATCH v3 3/4] vlan: Fix lockdep warning with stacked vlan devices Vlad Yasevich
2014-05-16 21:04 ` [PATCH v3 4/4] macvlan: Fix lockdep warnings with stacked macvlan devices Vlad Yasevich
2014-05-18 16:36 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400274296-14765-1-git-send-email-vyasevic@redhat.com \
--to=vyasevic@redhat.com \
--cc=dingtianhong@huawei.com \
--cc=jiri@resnulli.us \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).