From: Vlad Yasevich <vyasevic@redhat.com>
To: netdev@vger.kernel.org
Cc: vfalico@gmail.com, kaber@trash.net, j.vosburgh@gmail.com,
andy@greyhouse.net, Vlad Yasevich <vyasevic@redhat.com>
Subject: [PATCH v2 0/2] Fixed stacked vlan usage on top of bonds
Date: Fri, 16 May 2014 17:20:37 -0400 [thread overview]
Message-ID: <1400275239-15419-1-git-send-email-vyasevic@redhat.com> (raw)
Bonding device driver now support q-in-q on top for bonds. There are
a few issues here though.
First, when arp monitoring is used, bonding driver will not correctly
tag traffic if the source of the arp device was configured on top of
q-in-q. It may also incorrectly pick the wrong vlan id if the ordering
of that upper devices isn't as expected (there is no guarntee on ordering).
Second, the alb/tlb may use what would be considered 'inner' vlans in
its learning announcements, as it simply announces all vlans configured
on top of the bond without regard for encapsulation/stacking.
This series fixes the above 2 issues. This series also depends on the
functionality introduced in
http://patchwork.ozlabs.org/patch/349766/
Since v1:
- Changed how patch1 verifies the device path. We no longer use the
_all_upper version of the function. We find the path and if it was
found, then collect the vlan information.
- Use the constant to devine maximum vlan nest level support on top
of bonding. This can be changed if 2 is too low.
- Inlude patch2 into the series.
Vlad Yasevich (2):
bonding: Fix stacked device detection in arp monitoring
bonding: Fix alb mode to only use first level vlans.
drivers/net/bonding/bond_alb.c | 2 +-
drivers/net/bonding/bond_main.c | 134 +++++++++++++++++++---------------------
drivers/net/bonding/bonding.h | 1 +
include/linux/if_vlan.h | 6 ++
include/linux/netdevice.h | 9 +++
net/core/dev.c | 26 ++++++++
6 files changed, 108 insertions(+), 70 deletions(-)
--
1.9.0
next reply other threads:[~2014-05-16 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 21:20 Vlad Yasevich [this message]
2014-05-16 21:20 ` [PATCH v2 1/2] bonding: Fix stacked device detection in arp monitoring Vlad Yasevich
2014-05-16 21:20 ` [PATCH v2 2/2] bonding: Fix alb mode to only use first level vlans Vlad Yasevich
2014-05-17 2:29 ` [PATCH v2 0/2] Fixed stacked vlan usage on top of bonds David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400275239-15419-1-git-send-email-vyasevic@redhat.com \
--to=vyasevic@redhat.com \
--cc=andy@greyhouse.net \
--cc=j.vosburgh@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).