From: Vlad Yasevich <vyasevic@redhat.com>
To: netdev@vger.kernel.org
Cc: vfalico@gmail.com, kaber@trash.net, j.vosburgh@gmail.com,
andy@greyhouse.net, Vlad Yasevich <vyasevic@redhat.com>
Subject: [PATCH v2 2/2] bonding: Fix alb mode to only use first level vlans.
Date: Fri, 16 May 2014 17:20:39 -0400 [thread overview]
Message-ID: <1400275239-15419-3-git-send-email-vyasevic@redhat.com> (raw)
In-Reply-To: <1400275239-15419-1-git-send-email-vyasevic@redhat.com>
ALB/TLB learning packets use all vlans configured on top
of the bond. This ends up being incorrect if we have a stack
of vlans on top of the bond. ALB/TLB should only use
first level/outer most vlans in its announcements.
Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
---
drivers/net/bonding/bond_alb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index 9f69e81..e538478 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c
@@ -1045,7 +1045,7 @@ static void alb_send_learning_packets(struct slave *slave, u8 mac_addr[])
/* loop through vlans and send one packet for each */
rcu_read_lock();
netdev_for_each_all_upper_dev_rcu(bond->dev, upper, iter) {
- if (upper->priv_flags & IFF_802_1Q_VLAN)
+ if (is_vlan_dev(upper) && vlan_get_encap_level(upper) == 0)
alb_send_lp_vid(slave, mac_addr,
vlan_dev_vlan_id(upper));
}
--
1.9.0
next prev parent reply other threads:[~2014-05-16 21:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 21:20 [PATCH v2 0/2] Fixed stacked vlan usage on top of bonds Vlad Yasevich
2014-05-16 21:20 ` [PATCH v2 1/2] bonding: Fix stacked device detection in arp monitoring Vlad Yasevich
2014-05-16 21:20 ` Vlad Yasevich [this message]
2014-05-17 2:29 ` [PATCH v2 0/2] Fixed stacked vlan usage on top of bonds David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400275239-15419-3-git-send-email-vyasevic@redhat.com \
--to=vyasevic@redhat.com \
--cc=andy@greyhouse.net \
--cc=j.vosburgh@gmail.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).