[PATCH net-next] i40evf: Use is_multicast_ether_addr helper

[PATCH net-next] i40evf: Use is_multicast_ether_addr helper

[Tobias Klauser]

Use the is_multicast_ether_addr helper function from linux/etherdevice.h
instead of open coding the multicast address check.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
 drivers/net/ethernet/intel/i40evf/i40evf_main.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
index 6edd581..8b5c734 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
@@ -843,7 +843,7 @@ static void i40evf_set_rx_mode(struct net_device *netdev)
 	list_for_each_entry_safe(f, ftmp, &adapter->mac_filter_list, list) {
 		bool found = false;
 
-		if (f->macaddr[0] & 0x01) {
+		if (is_multicast_ether_addr(f->macaddr)) {
 			netdev_for_each_mc_addr(mca, netdev) {
 				if (ether_addr_equal(mca->addr, f->macaddr)) {
 					found = true;
-- 
1.7.9.5

Re: [PATCH net-next] i40evf: Use is_multicast_ether_addr helper

[David Miller]

From: Tobias Klauser <tklauser@distanz.ch>
Date: Fri, 16 May 2014 10:00:34 +0200

> Use the is_multicast_ether_addr helper function from linux/etherdevice.h
> instead of open coding the multicast address check.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>

Likewise, I'll let Jeff Kirsher take this via his tree.

Re: [PATCH net-next] i40evf: Use is_multicast_ether_addr helper

[Jeff Kirsher]

[-- Attachment #1.1: Type: text/plain, Size: 419 bytes --]

On Fri, 2014-05-16 at 10:00 +0200, Tobias Klauser wrote:
> Use the is_multicast_ether_addr helper function from
> linux/etherdevice.h
> instead of open coding the multicast address check.
> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  drivers/net/ethernet/intel/i40evf/i40evf_main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Tobias, I have added this to my queue.

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 385 bytes --]

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs

[-- Attachment #3: Type: text/plain, Size: 257 bytes --]

_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired