* [PATCH 3/4] atm: idt77252: Remove redundant error check
@ 2014-05-17 18:22 Peter Senna Tschudin
2014-05-19 1:14 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Peter Senna Tschudin @ 2014-05-17 18:22 UTC (permalink / raw)
To: Chas Williams
Cc: Peter Senna Tschudin, linux-atm-general, netdev, linux-kernel,
kernel-janitors
Remove double checks, and move the call to printk to the
first check. Also adds KERN_WARNING to printk. The simplified version
of the coccinelle semantic patch that fixes this issue is as follows:
// <smpl>
@@
expression E; identifier pr; expression list es;
@@
while(...){
...
- if (E) break;
+ if (E){
+ pr(es);
+ break;
+ }
...
}
- if(E) pr(es);
// </smpl>
Tested by compilation only.
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
---
drivers/atm/idt77252.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/atm/idt77252.c b/drivers/atm/idt77252.c
index 1bdf104..a8b6402 100644
--- a/drivers/atm/idt77252.c
+++ b/drivers/atm/idt77252.c
@@ -2551,12 +2551,12 @@ done:
timeout = 5 * 1000;
while (atomic_read(&vc->scq->used) > 0) {
timeout = msleep_interruptible(timeout);
- if (!timeout)
+ if (!timeout) {
+ printk(KERN_WARNING "%s: SCQ drain timeout: %u used\n",
+ card->name, atomic_read(&vc->scq->used));
break;
+ }
}
- if (!timeout)
- printk("%s: SCQ drain timeout: %u used\n",
- card->name, atomic_read(&vc->scq->used));
writel(TCMDQ_HALT | vc->index, SAR_REG_TCMDQ);
clear_scd(card, vc->scq, vc->class);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 3/4] atm: idt77252: Remove redundant error check
2014-05-17 18:22 [PATCH 3/4] atm: idt77252: Remove redundant error check Peter Senna Tschudin
@ 2014-05-19 1:14 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-05-19 1:14 UTC (permalink / raw)
To: peter.senna
Cc: chas, linux-atm-general, netdev, linux-kernel, kernel-janitors
From: Peter Senna Tschudin <peter.senna@gmail.com>
Date: Sat, 17 May 2014 20:22:59 +0200
> Remove double checks, and move the call to printk to the
> first check. Also adds KERN_WARNING to printk. The simplified version
> of the coccinelle semantic patch that fixes this issue is as follows:
The appropriate thing to use is pr_warning() rather than add
KERN_WARNING.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-19 1:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-17 18:22 [PATCH 3/4] atm: idt77252: Remove redundant error check Peter Senna Tschudin
2014-05-19 1:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).