From: Veaceslav Falico <vfalico@gmail.com>
To: netdev@vger.kernel.org
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Veaceslav Falico <vfalico@gmail.com>
Subject: [PATCH net-next 0/2] bonding: remove rlb_enabled and alb_set_mac_address()
Date: Thu, 22 May 2014 15:12:02 +0200 [thread overview]
Message-ID: <1400764324-23221-1-git-send-email-vfalico@gmail.com> (raw)
Hi,
Currently rlb_enabled works as
rlb_enabled == (BOND_MODE(bond) == BOND_MODE_ALB)
so we can always use this verification and drop maintenance of this
variable.
alb_set_mac_address(), OTOH, isn't used at all (as the mac changing logic
is used in other parts), and isn't ever called, so it's safe to remove it
as well.
CC: Jay Vosburgh <j.vosburgh@gmail.com>
CC: Andy Gospodarek <andy@greyhouse.net>
CC: netdev@vger.kernel.org
Signed-off-by: Veaceslav Falico <vfalico@gmail.com>
---
drivers/net/bonding/bond_alb.c | 95 ++++++-----------------------------------
drivers/net/bonding/bond_alb.h | 3 +-
drivers/net/bonding/bond_main.c | 2 +-
3 files changed, 16 insertions(+), 84 deletions(-)
next reply other threads:[~2014-05-22 13:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 13:12 Veaceslav Falico [this message]
2014-05-22 13:12 ` [PATCH net-next 1/2] bonding: remove rlb_enabled and use mode == ALB instead Veaceslav Falico
2014-05-22 13:12 ` [PATCH net-next 2/2] bonding: remove alb_set_mac_address() Veaceslav Falico
2014-05-22 14:36 ` Or Gerlitz
2014-05-22 14:57 ` Veaceslav Falico
2014-05-23 6:38 ` Or Gerlitz
2014-05-22 15:28 ` Vlad Yasevich
2014-05-22 15:56 ` Veaceslav Falico
2014-05-22 18:37 ` Jay Vosburgh
2014-05-22 21:22 ` [PATCH net-next 0/2] bonding: remove rlb_enabled and alb_set_mac_address() David Miller
2014-07-06 13:56 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400764324-23221-1-git-send-email-vfalico@gmail.com \
--to=vfalico@gmail.com \
--cc=andy@greyhouse.net \
--cc=j.vosburgh@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).