From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Stein Subject: [PATCH 4/6] pch_gbe: remove unnecessary PHY resets Date: Mon, 26 May 2014 15:40:37 +0200 Message-ID: <1401111639-11507-4-git-send-email-alexander.stein@systec-electronic.com> References: <1401111639-11507-1-git-send-email-alexander.stein@systec-electronic.com> Cc: Daniel Krueger , netdev@vger.kernel.org, Alexander Stein To: "David S. Miller" Return-path: Received: from webbox1416.server-home.net ([77.236.96.61]:58896 "EHLO webbox1416.server-home.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752554AbaEZNm2 (ORCPT ); Mon, 26 May 2014 09:42:28 -0400 In-Reply-To: <1401111639-11507-1-git-send-email-alexander.stein@systec-electronic.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Daniel Krueger Those PHY software resets destroy the painfully made PHY settings. Signed-off-by: Daniel Krueger Signed-off-by: Alexander Stein --- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c | 2 -- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c index 826f0cc..fbfac98 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool.c @@ -111,8 +111,6 @@ static int pch_gbe_set_settings(struct net_device *netdev, u32 speed = ethtool_cmd_speed(ecmd); int ret; - pch_gbe_hal_write_phy_reg(hw, MII_BMCR, BMCR_RESET); - /* when set_settings() is called with a ethtool_cmd previously * filled by get_settings() on a down link, speed is -1: */ if (speed == UINT_MAX) { diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c index a5cad5e..3fa9a8f 100644 --- a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c +++ b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_phy.c @@ -320,7 +320,6 @@ void pch_gbe_phy_init_setting(struct pch_gbe_hw *hw) cmd.duplex = hw->mac.link_duplex; cmd.advertising = hw->phy.autoneg_advertised; cmd.autoneg = hw->mac.autoneg; - pch_gbe_phy_write_reg_miic(hw, MII_BMCR, BMCR_RESET); ret = mii_ethtool_sset(&adapter->mii, &cmd); if (ret) netdev_err(adapter->netdev, "Error: mii_ethtool_sset\n"); -- 1.8.5.5