From: Joe Perches <joe@perches.com>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Daniel Krueger <daniel.krueger@systec-electronic.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/6] pch_gbe: print invalid MAC address during probe
Date: Mon, 26 May 2014 09:24:28 -0700 [thread overview]
Message-ID: <1401121468.519.6.camel@joe-AO725> (raw)
In-Reply-To: <1401111639-11507-1-git-send-email-alexander.stein@systec-electronic.com>
On Mon, 2014-05-26 at 15:40 +0200, Alexander Stein wrote:
> show the actual offending MAC address instead of just
> rejecting it
[]
> diff --git a/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c b/drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c
[]
> @@ -2674,6 +2674,7 @@ static int pch_gbe_probe(struct pci_dev *pdev,
> */
> dev_err(&pdev->dev, "Invalid MAC address, "
> "interface disabled.\n");
> + dev_err(&pdev->dev, "%pM\n", adapter->hw.mac.addr);
Nicer I think on a single line
using just one dev_err
dev_err(&pdev->dev, "Invalid MAC %pM - interface disabled\n",
adapter->hw.mac.addr);
next prev parent reply other threads:[~2014-05-26 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 13:40 [PATCH 1/6] pch_gbe: print invalid MAC address during probe Alexander Stein
2014-05-26 13:40 ` [PATCH 2/6] pch_gbe: Add module parameter for RGMII/GMII PHY mode selection Alexander Stein
2014-05-26 13:40 ` [PATCH 3/6] pch_gbe: change order of PHY address discovering Alexander Stein
2014-05-26 13:40 ` [PATCH 4/6] pch_gbe: remove unnecessary PHY resets Alexander Stein
2014-05-26 13:40 ` [PATCH 5/6] pch_gbe: reset PHY before first configuration Alexander Stein
2014-05-26 13:40 ` [PATCH 6/6] pch_gbe: remove shutdown and restart of interface after PHY settings change Alexander Stein
2014-05-26 16:24 ` Joe Perches [this message]
2014-05-28 9:34 ` [PATCH 1/6] pch_gbe: print invalid MAC address during probe Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401121468.519.6.camel@joe-AO725 \
--to=joe@perches.com \
--cc=alexander.stein@systec-electronic.com \
--cc=daniel.krueger@systec-electronic.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).