From: Toshiaki Makita <toshiaki.makita1@gmail.com>
To: vyasevic@redhat.com
Cc: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>,
"David S . Miller" <davem@davemloft.net>,
Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [Bridge] [PATCH net] bridge: Prevent insertion of FDB entry with disallowed vlan
Date: Wed, 28 May 2014 23:32:50 +0900 [thread overview]
Message-ID: <1401287570.1873.4.camel@localhost.localdomain> (raw)
In-Reply-To: <5385EC5D.40106@redhat.com>
On Wed, 2014-05-28 at 10:02 -0400, Vlad Yasevich wrote:
...
>
> This is very similar to br_allow_ingress(), so may be you can
> re-factor so that we only have 1 such function...
Yes.. indeed, this looks redundant.
What bothered me is br_allowed_ingress() modifies or drops frames but
I'm not expecting it here.
Maybe we can hand a hint to br_allowed_ingress so that it doesn't modify
the skb?
Thanks,
Toshiaki Makita
next prev parent reply other threads:[~2014-05-28 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 6:15 [PATCH net] bridge: Prevent insertion of FDB entry with disallowed vlan Toshiaki Makita
2014-05-28 14:02 ` Vlad Yasevich
2014-05-28 14:32 ` Toshiaki Makita [this message]
2014-05-30 22:48 ` David Miller
2014-06-02 14:22 ` Vlad Yasevich
2014-06-02 20:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401287570.1873.4.camel@localhost.localdomain \
--to=toshiaki.makita1@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).