From: Joe Perches <joe@perches.com>
To: Benoit Taine <benoit.taine@lip6.fr>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] lpc_eth: Use resource_size instead of computation
Date: Wed, 28 May 2014 09:16:56 -0700 [thread overview]
Message-ID: <1401293816.19335.3.camel@joe-AO725> (raw)
In-Reply-To: <1401290047-30005-3-git-send-email-benoit.taine@lip6.fr>
On Wed, 2014-05-28 at 17:14 +0200, Benoit Taine wrote:
> This issue was reported by coccicheck using the semantic patch
> at scripts/coccinelle/api/resource_size.cocci
Slightly associated trivial note:
> diff --git a/drivers/net/ethernet/nxp/lpc_eth.c b/drivers/net/ethernet/nxp/lpc_eth.c
[]
> @@ -1419,8 +1419,7 @@ static int lpc_eth_drv_probe(struct platform_device *pdev)
>
> netdev_dbg(ndev, "IO address start :0x%08x\n",
> res->start);
> - netdev_dbg(ndev, "IO address size :%d\n",
> - res->end - res->start + 1);
> + netdev_dbg(ndev, "IO address size :%d\n", resource_size(res));
May be better using:
netdev_dbg(ndev, "IO :%pR\n", res)
next prev parent reply other threads:[~2014-05-28 16:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 15:14 [PATCH 0/2] Use resource_size instead of computation Benoit Taine
2014-05-28 15:14 ` [PATCH 2/2] lpc_eth: " Benoit Taine
2014-05-28 16:16 ` Joe Perches [this message]
2014-06-02 2:27 ` David Miller
2014-06-02 11:24 ` [PATCH 2/2 v2] " Benoit Taine
2014-06-02 11:34 ` [PATCH 2/2 v3] " Benoit Taine
2014-06-02 17:58 ` David Miller
2014-06-03 10:32 ` [PATCH 2/2 v4] " Benoit Taine
2014-06-03 10:45 ` [PATCH 2/2 v5] " Benoit Taine
2014-06-03 23:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401293816.19335.3.camel@joe-AO725 \
--to=joe@perches.com \
--cc=benoit.taine@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).