From: Joe Perches <joe@perches.com>
To: frank.blaschka@de.ibm.com
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-s390@vger.kernel.org,
Ursula Braun <ursula.braun@de.ibm.com>,
Toralf Foerster <toralf.foerster@gmx.de>
Subject: Re: [patch 4/4] s390/net: fix format string mismatches
Date: Wed, 28 May 2014 09:22:31 -0700 [thread overview]
Message-ID: <1401294151.19335.6.camel@joe-AO725> (raw)
In-Reply-To: <20140528082239.994360709@de.ibm.com>
Hi Frank:
A trivial note:
On Wed, 2014-05-28 at 10:22 +0200, frank.blaschka@de.ibm.com wrote:
(submitting a patch containing changes like)
+ rc = sscanf(buf, "%u", &bs1);
+ if (rc != 1)
+ goto einval;
All of these single var sscanf uses could be
changed to kstrto<foo>
next prev parent reply other threads:[~2014-05-28 16:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 8:22 [patch 0/4] s390: network patches for net-next V1 frank.blaschka
2014-05-28 8:22 ` [patch 1/4] af_iucv: Add automatic (source) iucv_name to bind frank.blaschka
2014-05-28 8:22 ` [patch 2/4] af_iucv: correct cleanup if listen backlog is full frank.blaschka
2014-05-28 8:22 ` [patch 3/4] qeth: Fix for possible null pointer dereference frank.blaschka
2014-05-28 8:22 ` [patch 4/4] s390/net: fix format string mismatches frank.blaschka
2014-05-28 16:22 ` Joe Perches [this message]
2014-05-31 0:35 ` [patch 0/4] s390: network patches for net-next V1 David Miller
-- strict thread matches above, loose matches on Subject: below --
2014-05-27 9:13 [patch 0/4] s390: network patches for net-next frank.blaschka
2014-05-27 9:13 ` [patch 4/4] s390/net: fix format string mismatches frank.blaschka
2014-05-27 9:34 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401294151.19335.6.camel@joe-AO725 \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=frank.blaschka@de.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=toralf.foerster@gmx.de \
--cc=ursula.braun@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).