From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [patch 4/4] s390/net: fix format string mismatches Date: Wed, 28 May 2014 09:22:31 -0700 Message-ID: <1401294151.19335.6.camel@joe-AO725> References: <20140528082227.024995099@de.ibm.com> <20140528082239.994360709@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-s390@vger.kernel.org, Ursula Braun , Toralf Foerster To: frank.blaschka@de.ibm.com Return-path: Received: from smtprelay0057.hostedemail.com ([216.40.44.57]:60924 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752387AbaE1QWk (ORCPT ); Wed, 28 May 2014 12:22:40 -0400 In-Reply-To: <20140528082239.994360709@de.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi Frank: A trivial note: On Wed, 2014-05-28 at 10:22 +0200, frank.blaschka@de.ibm.com wrote: (submitting a patch containing changes like) + rc = sscanf(buf, "%u", &bs1); + if (rc != 1) + goto einval; All of these single var sscanf uses could be changed to kstrto