From: Daniel Mack <zonque@gmail.com>
To: linux-next@vger.kernel.org, davem@davemloft.net
Cc: netdev@vger.kernel.org, sfr@canb.auug.org.au,
Daniel Mack <zonque@gmail.com>
Subject: [PATCH 1/2] net: of_mdio: use int type for address variable
Date: Mon, 2 Jun 2014 13:32:45 +0200 [thread overview]
Message-ID: <1401708766-5530-1-git-send-email-zonque@gmail.com> (raw)
Use int rather than u32 to fix the following warning:
drivers/of/of_mdio.c:147 of_mdiobus_register() warn: unsigned 'addr' is
never less than zero.
Signed-off-by: Daniel Mack <zonque@gmail.com>
Fixes: 8f8382888cba ("net: of_mdio: factor out code to parse a phy's 'reg' property")
---
David,
this patch and the next one fix warnings and build breakage reported
by Stephen and the build test system. They were both introduced by
my patches that you applied lately.
Thanks,
Daniel
drivers/of/of_mdio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
index c719601..cb36018 100644
--- a/drivers/of/of_mdio.c
+++ b/drivers/of/of_mdio.c
@@ -147,9 +147,8 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np)
{
struct device_node *child;
const __be32 *paddr;
- u32 addr;
bool scanphys = false;
- int rc, i;
+ int addr, rc, i;
/* Mask out all PHYs from auto probing. Instead the PHYs listed in
* the device tree are populated after the bus has been registered */
--
1.9.0
next reply other threads:[~2014-06-02 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 11:32 Daniel Mack [this message]
2014-06-02 11:32 ` [PATCH 2/2] of: of_mdio: export symbol of_mdiobus_link_phydev Daniel Mack
2014-06-02 17:43 ` David Miller
2014-06-02 17:43 ` [PATCH 1/2] net: of_mdio: use int type for address variable David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401708766-5530-1-git-send-email-zonque@gmail.com \
--to=zonque@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).